From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1108FC43334 for ; Wed, 15 Jun 2022 17:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357493AbiFORX6 (ORCPT ); Wed, 15 Jun 2022 13:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344717AbiFORX5 (ORCPT ); Wed, 15 Jun 2022 13:23:57 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D8237003 for ; Wed, 15 Jun 2022 10:23:56 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id z14so7831549pgh.0 for ; Wed, 15 Jun 2022 10:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uQzT9M+wirjRWTALR/Ctil1z3dCrk4kc07t01L80RXo=; b=J/mzUAtY7HFHAhHvR2gggx1KG7QYBDhZ3DOnNXM2JXfomAjEJ78beMxayCw4L0L+ZL SotETEomqUpouk7DAFyVhRC7qld5i8nY6Pc3+0nhoNyDrmbNkzUOs5428wvxkUIgw8LJ RahTG2ALvpAz+6/pv3QnvEmhR9tvVlPkYI6eCwAIW2DioCeexX1R3vM2alzUnWBKam1x In2q6a40Y/HlgQWnFDKtt6P06VQfgzcIYvM+Jdn1H6TNsaTG/gZtzXpIc/4ueyN+rZwg y3WRr191VTkvzCBKZvoYqWRpzvdC/SiBjz4FLa0tiDwyBVmIaWIuy/nbkWAashS34k/i Em2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uQzT9M+wirjRWTALR/Ctil1z3dCrk4kc07t01L80RXo=; b=UgWN/FKcy2B+RARPeQd3tV4syIMfxv28GHItuYHEwWo2wzEAi0QByJZtwJpPXlq4v7 87MjQ8K5oVsUj2M0zTJ7SqV24S6ttCp8ELKrws0ffJutZH2Qx5Ih4G+k8Ilo/NlaMq4X /gdHD1uBpS/DZvV+2q69hUTw8lGGuuYqvtu8j2vhvQHSY3WS6YERPjRnKx+ijbedd7e6 k426Rlt5xeRfwCgBfJg+qFCJhbtZJmsH15Tq2EuThJaLtMSiAp6l0h6PevRXIe5ZPl/O KqY9IMJtowUKmCadhjtYP+BN6LS3tbO4/e2I76ucs+IbYh8qfEVrdgzMFkdVTIAqIiik BZBQ== X-Gm-Message-State: AJIora82e0elrhI9JfJ8E5pA8au/Ks4Z68xD6pwLuGRhPH6T1vtnv/d/ 9i2vpaZpvC747G+Fw/Dpj/L3oA== X-Google-Smtp-Source: AGRyM1u8esQ1tilHUI1WkY7e3mLOm1U8h0S3L/MsXoduHlEGJA3frw9eZXYydBPsK1xgTQa7XC9MAg== X-Received: by 2002:a05:6a00:9a2:b0:505:974f:9fd6 with SMTP id u34-20020a056a0009a200b00505974f9fd6mr559898pfg.12.1655313836466; Wed, 15 Jun 2022 10:23:56 -0700 (PDT) Received: from [172.22.33.138] ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b0050dc762817esm10169267pfu.88.2022.06.15.10.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jun 2022 10:23:56 -0700 (PDT) Message-ID: <450937fd-8067-21c3-344e-18769257ee10@linaro.org> Date: Wed, 15 Jun 2022 10:23:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 1/3] dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger Content-Language: en-US To: Artur Rojek , Chris Morgan Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, maccraft123mc@gmail.com, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, Chris Morgan References: <20220613192353.696-1-macroalpha82@gmail.com> <20220613192353.696-2-macroalpha82@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 14/06/2022 18:50, Artur Rojek wrote: > On 2022-06-13 21:23, Chris Morgan wrote: >> From: Chris Morgan >> >> Add documentation for adc-joystick,no-hardware-trigger. New device-tree >> properties have been added. >> >> - adc-joystick,no-hardware-trigger: A boolean value noting the joystick >> device should be polled rather than >> use a triggered buffer. >> >> Signed-off-by: Maya Matuszczyk >> Signed-off-by: Chris Morgan >> --- >> .../devicetree/bindings/input/adc-joystick.yaml | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml >> b/Documentation/devicetree/bindings/input/adc-joystick.yaml >> index 2ee04e03bc22..627cc6c40191 100644 >> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml >> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml >> @@ -12,12 +12,19 @@ maintainers: >> >> description: > >> Bindings for joystick devices connected to ADC controllers >> supporting >> - the Industrial I/O subsystem. >> + the Industrial I/O subsystem. Supports both polled devices where no >> + iio trigger is available and non-polled devices which are triggered >> + by iio. >> >> properties: >> compatible: >> const: adc-joystick >> >> + adc-joystick,no-hardware-trigger: > I'm against using Device Tree for this functionality. See my reply to > patch 2/3 for details. I am surprised to see v3 after that comment... > But in case we do end up going DT way, I would much prefer going with > Rob's suggestion of using the existing `poll-interval` input property. +1 here as well, if above does not work. Best regards, Krzysztof