From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Wesley Cheng <quic_wcheng@quicinc.com>,
srinivas.kandagatla@linaro.org, mathias.nyman@intel.com,
perex@perex.cz, conor+dt@kernel.org, dmitry.torokhov@gmail.com,
corbet@lwn.net, broonie@kernel.org, lgirdwood@gmail.com,
tiwai@suse.com, krzk+dt@kernel.org, Thinh.Nguyen@synopsys.com,
bgoswami@quicinc.com, robh@kernel.org,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-sound@vger.kernel.org, linux-input@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-doc@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v28 00/32] Introduce QC USB SND audio offloading support
Date: Wed, 25 Sep 2024 17:04:20 +0200 [thread overview]
Message-ID: <4552c7fb-2c59-485d-af67-0bf36d2424e5@linux.intel.com> (raw)
In-Reply-To: <20240925010000.2231406-1-quic_wcheng@quicinc.com>
Overall the patchset is much improved but you still have misleading
information, see e.g. the rather poor description of error codes for the
update_offload_route() helper.
I hope other reviewers step-in to cover this large set of patches...
Cheers,
-Pierre
next prev parent reply other threads:[~2024-09-25 15:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 0:59 [PATCH v28 00/32] Introduce QC USB SND audio offloading support Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 01/32] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 02/32] usb: host: xhci: Repurpose event handler for skipping interrupter events Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 03/32] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 04/32] usb: xhci: xhci-sideband: Set IMOD for xHCI sideband clients Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 05/32] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 06/32] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 07/32] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 08/32] usb: dwc3: Specify maximum number of XHCI interrupters Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 09/32] ALSA: Add USB audio device jack type Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 10/32] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 11/32] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 12/32] ALSA: usb-audio: Save UAC sample size information Wesley Cheng
2024-09-25 14:22 ` Pierre-Louis Bossart
2024-09-25 0:59 ` [PATCH v28 13/32] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 14/32] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 15/32] ASoC: usb: Add PCM format check API for " Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 16/32] ASoC: usb: Create SOC USB SND jack kcontrol Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 17/32] ASoC: usb: Fetch ASoC card and pcm device information Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 18/32] ASoC: doc: Add documentation for SOC USB Wesley Cheng
2024-09-25 14:43 ` Pierre-Louis Bossart
2024-10-01 1:34 ` Wesley Cheng
2024-10-01 13:48 ` Amadeusz Sławiński
2024-09-25 0:59 ` [PATCH v28 19/32] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 20/32] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 21/32] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 22/32] ASoC: qcom: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 23/32] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 24/32] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 25/32] ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device Wesley Cheng
2024-09-25 14:48 ` Pierre-Louis Bossart
2024-09-25 0:59 ` [PATCH v28 26/32] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 27/32] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 28/32] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 29/32] ALSA: usb-audio: qcom: Don't allow USB offload path if PCM device is in use Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 30/32] ALSA: usb-audio: Add USB offload route kcontrol Wesley Cheng
2024-09-25 14:54 ` Pierre-Louis Bossart
2024-09-25 19:37 ` Wesley Cheng
2024-09-25 0:59 ` [PATCH v28 31/32] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2024-09-25 1:00 ` [PATCH v28 32/32] ASoC: usb: Rediscover USB SND devices on USB port add Wesley Cheng
2024-09-25 15:04 ` Pierre-Louis Bossart [this message]
2024-10-01 13:50 ` [PATCH v28 00/32] Introduce QC USB SND audio offloading support Amadeusz Sławiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4552c7fb-2c59-485d-af67-0bf36d2424e5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=perex@perex.cz \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).