From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: [PATCH] Added device to hid-ff Date: Thu, 15 Feb 2007 21:51:07 +0200 Message-ID: <45D4B9AB.70509@gmail.com> References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: "STenyaK (Bruno Gonzalez)" , johann deneux , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org Dmitry Torokhov wrote: > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: >> Sorry for not providing a proper patch, could you please also add >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel >> to the list? I tested it here and that wheel is also working. >> > > OK. > Hmm.. Shouldn't an entry also be added to the devices[] list in hid-lgff.c for these devices? (and it seems one device is already missing from there in the current kernel). I'm not able to check right now, but I think some earlier kernels may have defaulted to ff_joystick if no entry is present in devices[], hence these devices working for some without the entry. (so the alternative is to restore that behaviour) BTW, shouldn't the PID/VID check in hid_lgff_init() do endian conversion? -- Anssi Hannula