* [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe()
@ 2018-01-21 19:19 SF Markus Elfring
2018-01-22 7:00 ` Martin Kepplinger
2018-01-22 7:43 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-01-21 19:19 UTC (permalink / raw)
To: linux-input, Andi Shyti, Dmitry Torokhov, Günter Röck,
Martin Kepplinger, Rob Herring, Simon Budig,
Stefan Schöfegger
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 Jan 2018 20:10:03 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/touchscreen/edt-ft5x06.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index c53a3d7239e7..9d2799c90150 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n");
tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL);
- if (!tsdata) {
- dev_err(&client->dev, "failed to allocate driver data.\n");
+ if (!tsdata)
return -ENOMEM;
- }
chip_data = of_device_get_match_data(&client->dev);
if (!chip_data)
--
2.16.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe()
2018-01-21 19:19 [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() SF Markus Elfring
@ 2018-01-22 7:00 ` Martin Kepplinger
2018-01-22 7:43 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Martin Kepplinger @ 2018-01-22 7:00 UTC (permalink / raw)
To: SF Markus Elfring, linux-input, Andi Shyti, Dmitry Torokhov,
Günter Röck, Rob Herring, Simon Budig,
Stefan Schöfegger
Cc: LKML, kernel-janitors
On 2018-01-21 20:19, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 21 Jan 2018 20:10:03 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index c53a3d7239e7..9d2799c90150 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
> dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n");
>
> tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL);
> - if (!tsdata) {
> - dev_err(&client->dev, "failed to allocate driver data.\n");
> + if (!tsdata)
> return -ENOMEM;
> - }
>
> chip_data = of_device_get_match_data(&client->dev);
> if (!chip_data)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe()
2018-01-21 19:19 [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() SF Markus Elfring
2018-01-22 7:00 ` Martin Kepplinger
@ 2018-01-22 7:43 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2018-01-22 7:43 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-input, Andi Shyti, Dmitry Torokhov, Günter Röck,
Martin Kepplinger, Rob Herring, Simon Budig,
Stefan Schöfegger, LKML, kernel-janitors
Hi Markus,
On Sun, Jan 21, 2018 at 08:19:00PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 21 Jan 2018 20:10:03 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Andi Shyti <andi@etezian.org>
Thanks,
Andi
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index c53a3d7239e7..9d2799c90150 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
> dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n");
>
> tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL);
> - if (!tsdata) {
> - dev_err(&client->dev, "failed to allocate driver data.\n");
> + if (!tsdata)
> return -ENOMEM;
> - }
>
> chip_data = of_device_get_match_data(&client->dev);
> if (!chip_data)
> --
> 2.16.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-21 19:19 [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() SF Markus Elfring
2018-01-22 7:00 ` Martin Kepplinger
2018-01-22 7:43 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).