From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: dmitry.torokhov@gmail.com, jkosina@suse.cz
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Elias Vanderstuyft <elias.vds@gmail.com>
Subject: [PATCH 11/24] Port hid-holtekff to ff-memless-next
Date: Wed, 09 Apr 2014 13:23:10 +0200 [thread overview]
Message-ID: <465682905.2FXXEpasa4@sigyn> (raw)
In-Reply-To: <1609685.QRL9N9sQvX@sigyn>
Port hid-holtekff to ff-memless-next
Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net>
---
drivers/hid/Kconfig | 2 +-
drivers/hid/hid-holtekff.c | 47 +++++++++++++++++++++++++++++-----------------
2 files changed, 31 insertions(+), 18 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 24b336e..d1d4e77 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -247,7 +247,7 @@ config HID_HOLTEK
config HOLTEK_FF
bool "Holtek On Line Grip force feedback support"
depends on HID_HOLTEK
- select INPUT_FF_MEMLESS
+ select INPUT_FF_MEMLESS_NEXT
---help---
Say Y here if you have a Holtek On Line Grip based game controller
and want to have force feedback support for it.
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
index 9325545..9c6064d 100644
--- a/drivers/hid/hid-holtekff.c
+++ b/drivers/hid/hid-holtekff.c
@@ -27,9 +27,12 @@
#include <linux/input.h>
#include <linux/module.h>
#include <linux/slab.h>
+#include <linux/input/ff-memless-next.h>
#include "hid-ids.h"
+#define FF_UPDATE_RATE 50
+
#ifdef CONFIG_HOLTEK_FF
MODULE_LICENSE("GPL");
@@ -104,34 +107,44 @@ static void holtekff_send(struct holtekff_device *holtekff,
}
static int holtekff_play(struct input_dev *dev, void *data,
- struct ff_effect *effect)
+ const struct mlnx_effect_command *command)
{
struct hid_device *hid = input_get_drvdata(dev);
struct holtekff_device *holtekff = data;
+ const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
int left, right;
/* effect type 1, length 65535 msec */
u8 buf[HOLTEKFF_MSG_LENGTH] =
{ 0x01, 0x01, 0xff, 0xff, 0x10, 0xe0, 0x00 };
- left = effect->u.rumble.strong_magnitude;
- right = effect->u.rumble.weak_magnitude;
- dbg_hid("called with 0x%04x 0x%04x\n", left, right);
+ switch (command->cmd) {
+ case MLNX_START_RUMBLE:
+ left = rumble_force->strong;
+ right = rumble_force->weak;
+ dbg_hid("called with 0x%04x 0x%04x\n", left, right);
- if (!left && !right) {
- holtekff_send(holtekff, hid, stop_all6);
- return 0;
- }
+ if (!left && !right) {
+ holtekff_send(holtekff, hid, stop_all6);
+ return 0;
+ }
- if (left)
- buf[1] |= 0x80;
- if (right)
- buf[1] |= 0x40;
+ if (left)
+ buf[1] |= 0x80;
+ if (right)
+ buf[1] |= 0x40;
- /* The device takes a single magnitude, so we just sum them up. */
- buf[6] = min(0xf, (left >> 12) + (right >> 12));
+ /* The device takes a single magnitude, so we just sum them up. */
+ buf[6] = min(0xf, (left >> 12) + (right >> 12));
- holtekff_send(holtekff, hid, buf);
- holtekff_send(holtekff, hid, start_effect_1);
+ holtekff_send(holtekff, hid, buf);
+ holtekff_send(holtekff, hid, start_effect_1);
+ return 0;
+ case MLNX_STOP_RUMBLE:
+ holtekff_send(holtekff, hid, stop_all6);
+ return 0;
+ default:
+ return -EINVAL;
+ }
return 0;
}
@@ -171,7 +184,7 @@ static int holtekff_init(struct hid_device *hid)
holtekff_send(holtekff, hid, stop_all4);
holtekff_send(holtekff, hid, stop_all6);
- error = input_ff_create_memless(dev, holtekff, holtekff_play);
+ error = input_ff_create_mlnx(dev, holtekff, holtekff_play, FF_UPDATE_RATE);
if (error) {
kfree(holtekff);
return error;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-09 11:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:10 [PATCH 0/24] Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-09 11:13 ` [PATCH 01/24] Add ff-memless-next module Michal Malý
2014-04-09 11:14 ` [PATCH 02/24] Port arizona-haptics to ff-memless-next Michal Malý
2014-04-09 11:15 ` [PATCH 03/24] Port twl4030-vibra " Michal Malý
2014-04-09 11:16 ` [PATCH 04/24] Port twl6040-vibra " Michal Malý
2014-04-09 11:17 ` [PATCH 05/24] Port max8997_haptic " Michal Malý
2014-04-09 11:17 ` [PATCH 06/24] Port pm8xxx-vibrator " Michal Malý
2014-04-09 11:18 ` [PATCH 07/24] Port hid-axff " Michal Malý
2014-04-09 11:19 ` [PATCH 08/24] Port hid-emsff " Michal Malý
2014-04-09 11:21 ` [PATCH 09/24] Port hid-dr " Michal Malý
2014-04-09 11:22 ` [PATCH 10/24] Port hid-gaff " Michal Malý
2014-04-09 11:23 ` Michal Malý [this message]
2014-04-09 11:24 ` [PATCH 12/24] Port hid-lgff " Michal Malý
2014-04-20 22:00 ` Elias Vanderstuyft
2014-04-09 11:24 ` [PATCH 13/24] Port hid-lg3ff " Michal Malý
2014-04-20 22:13 ` Elias Vanderstuyft
2014-04-09 11:25 ` [PATCH 14/24] Port hid-pl " Michal Malý
2014-04-09 11:26 ` [PATCH 15/24] Port hid-sjoy " Michal Malý
2014-04-09 11:27 ` [PATCH 16/24] Port hid-sony " Michal Malý
2014-04-09 11:28 ` [PATCH 17/24] Port hid-tmff " Michal Malý
2014-04-09 11:28 ` [PATCH 18/24] Port hid-wiimote-modules " Michal Malý
2014-04-09 11:29 ` [PATCH 19/24] Port hid-zpff " Michal Malý
2014-04-09 11:30 ` [PATCH 20/24] Port gamecon " Michal Malý
2014-04-09 11:31 ` [PATCH 21/24] Port xpad " Michal Malý
2014-04-09 11:33 ` [PATCH 22/24] Port hid-lg2ff " Michal Malý
2014-04-09 11:35 ` [PATCH 23/24] Port hid-lg4ff " Michal Malý
2014-04-20 17:27 ` simon
2014-04-09 11:36 ` [PATCH 24/24] Replace ff-memless with ff-memless-next Michal Malý
2014-04-20 17:27 ` [PATCH 0/24] Introduce ff-memless-next as an improved replacement for ff-memless simon
2014-04-20 22:05 ` Elias Vanderstuyft
2014-04-20 22:29 ` simon
2014-04-21 11:25 ` Elias Vanderstuyft
-- strict thread matches above, loose matches on Subject: below --
2014-04-22 13:45 [PATCH v2 00/24] input: " Michal Malý
2014-04-22 13:46 ` [PATCH 11/24] Port hid-holtekff to ff-memless-next Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465682905.2FXXEpasa4@sigyn \
--to=madcatxster@devoid-pointer.net \
--cc=dmitry.torokhov@gmail.com \
--cc=elias.vds@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).