* [patch] add printk_ratelimit to atkbd_interrupt
@ 2007-06-20 1:17 Qi Yong
2007-06-20 4:13 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Qi Yong @ 2007-06-20 1:17 UTC (permalink / raw)
To: dtor; +Cc: dmitry.torokhov, linux-input, linux-kernel, akpm
Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
screen. This patch helps to read the screen.
Signed-off-by: Qi Yong <qiyong@mail.fc-cn.com>
--
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index be1fe46..13e6bd4 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -408,9 +408,10 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
goto out;
case ATKBD_RET_ACK:
case ATKBD_RET_NAK:
- printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
- "Some program might be trying access hardware directly.\n",
- data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+ if (printk_ratelimit())
+ printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
+ "Some program might be trying access hardware directly.\n",
+ data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
goto out;
case ATKBD_RET_HANGEUL:
case ATKBD_RET_HANJA:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] add printk_ratelimit to atkbd_interrupt
2007-06-20 1:17 [patch] add printk_ratelimit to atkbd_interrupt Qi Yong
@ 2007-06-20 4:13 ` Dmitry Torokhov
2007-06-20 7:34 ` Qi Yong
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2007-06-20 4:13 UTC (permalink / raw)
To: Qi Yong; +Cc: linux-input, linux-kernel, akpm
On Tuesday 19 June 2007 21:17, Qi Yong wrote:
> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
> screen. This patch helps to read the screen.
>
Will apply, thank you.
Do you have any idea why you are getting spurios ACK messages? Do you have
an application fiddling with keyboard port or do you have blink driver
enabled?
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] add printk_ratelimit to atkbd_interrupt
2007-06-20 4:13 ` Dmitry Torokhov
@ 2007-06-20 7:34 ` Qi Yong
2007-06-21 3:07 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Qi Yong @ 2007-06-20 7:34 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, akpm, michal.k.k.piotrowski
Dmitry Torokhov wrote:
> On Tuesday 19 June 2007 21:17, Qi Yong wrote:
>
>> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
>> screen. This patch helps to read the screen.
>>
>>
>
> Will apply, thank you.
>
> Do you have any idea why you are getting spurios ACK messages? Do you have
> an application fiddling with keyboard port or do you have blink driver
> enabled?
No idea. It is at boot time.
Yes, i have CONFIG_BLINK=y.
(add CC: Michal Piotrowski)
--
Qi Yong
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] add printk_ratelimit to atkbd_interrupt
2007-06-20 7:34 ` Qi Yong
@ 2007-06-21 3:07 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2007-06-21 3:07 UTC (permalink / raw)
To: Qi Yong; +Cc: linux-input, linux-kernel, akpm, michal.k.k.piotrowski
On Wednesday 20 June 2007 03:34, Qi Yong wrote:
> Dmitry Torokhov wrote:
> > On Tuesday 19 June 2007 21:17, Qi Yong wrote:
> >
> >> Add printk_ratelimit() to atkbd_interrupt(). I get "Spurious ACK" messages flushing on my
> >> screen. This patch helps to read the screen.
> >>
> >>
> >
> > Will apply, thank you.
> >
> > Do you have any idea why you are getting spurios ACK messages? Do you have
> > an application fiddling with keyboard port or do you have blink driver
> > enabled?
>
> No idea. It is at boot time.
> Yes, i have CONFIG_BLINK=y.
Disable it.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-21 3:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-20 1:17 [patch] add printk_ratelimit to atkbd_interrupt Qi Yong
2007-06-20 4:13 ` Dmitry Torokhov
2007-06-20 7:34 ` Qi Yong
2007-06-21 3:07 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).