From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alfred E. Heggestad" Subject: Re: [PATCH] USB: driver for CM109 chipset Date: Tue, 26 Jun 2007 00:29:40 +0200 Message-ID: <468041D4.7090608@db.org> References: <467FC7E5.7050901@db.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: linux-input@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org Dmitry Torokhov wrote: > Hi Alfred, > > On 6/25/07, Alfred E. Heggestad wrote: >> From: Alfred E. Heggestad >> >> This driver adds support for USB VoIP phones using the CM109 chipset, >> such as the KIP-1000. Keypad is scanned and events are reported to >> the input subsystem. The buzzer can be activated by sending SND_TONE >> or SND_BELL to the input device. >> The driver has been tested with linux 2.6.21.3 on i386 and AMD64, >> and linux 2.6.21.1 on Broadcom BCM3302 (MIPS, OpenWRT Project) >> The current patch applies cleanly and is tested on linux 2.6.22-rc4 >> More testing and code review is welcome.. >> > > Thank you for your patch. I have couple of comments: > > - "input_dev->cdev.dev = &intf->dev;" should be "input_dev->dev.parent > = &intf->dev;" > - do not access input->private directly; use input_set_drvdata() and > input_get_drvdata() helpers. > - error handling for input_register_device(); thanks for the comments, this is now fixed locally and will be part of the new patch submitted tomorrow. > - I guess we need KEY_POUNDSIGN because I don't like that business > with key_shift + key_3 (I did not like it in yealink either...) > yes that would be nice. I copied the logic from yealink.c, which I also did not like, but I could not find any '#' signs in linux/input.h > Also could you please send your patches inline instead of an > attachment - it makes much easire to comment that way. > sure no problem. /alfred > Thanks! >