From: Jiri Slaby <jirislaby@gmail.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Haboustak <mike-@cinci.rr.com>, Andreas Gal <gal@uci.edu>,
Vojtech Pavlik <vojtech@suse.cz>,
Greg Kroah-Hartman <greg@kroah.com>,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH][hid] Fix a NULL pointer dereference when we fail to allocate memory
Date: Sun, 22 Jul 2007 07:47:33 +0200 [thread overview]
Message-ID: <46A2EF75.70700@gmail.com> (raw)
In-Reply-To: <200707220006.20359.jesper.juhl@gmail.com>
Jesper Juhl napsal(a):
> drivers/hid/usbhid/hid-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index b2baeae..3ff7468 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -743,7 +743,7 @@ static struct hid_device *usb_hid_configure(struct usb_interface *intf)
> hid->quirks = quirks;
>
> if (!(usbhid = kzalloc(sizeof(struct usbhid_device), GFP_KERNEL)))
Out of curiosity, where is this freed?
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
next prev parent reply other threads:[~2007-07-22 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 22:06 [PATCH][hid] Fix a NULL pointer dereference when we fail to allocate memory Jesper Juhl
2007-07-22 5:47 ` Jiri Slaby [this message]
2007-07-30 13:56 ` Jiri Kosina
2007-07-30 14:04 ` Jesper Juhl
2007-07-30 13:19 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A2EF75.70700@gmail.com \
--to=jirislaby@gmail.com \
--cc=gal@uci.edu \
--cc=greg@kroah.com \
--cc=jesper.juhl@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mike-@cinci.rr.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).