linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] HID: use hid-plff driver for GreenAsia 0e8f:0003 devices
@ 2007-09-18 18:23 Anssi Hannula
  2007-09-19  9:57 ` Jiri Kosina
  0 siblings, 1 reply; 3+ messages in thread
From: Anssi Hannula @ 2007-09-18 18:23 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-input

Add 0e8f:0003 into the list of devices supported by the hid-plff
force feedback driver. These devices identify themselves as
"GreenAsia Inc.    USB Joystick     " and can be either adapters or
actual game controllers. The testing was done with a Köng Gaming
gamepad.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>

---

Index: linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig
+++ linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig 2007-09-18 20:54:53.000000000 +0300
@@ -71,12 +71,12 @@
          force feedback.

 config PANTHERLORD_FF
-       bool "PantherLord USB/PS2 2in1 Adapter support"
+       bool "PantherLord/GreenAsia based device support"
        depends on HID_FF
        select INPUT_FF_MEMLESS if USB_HID
        help
-         Say Y here if you have a PantherLord USB/PS2 2in1 Adapter and want
-         to enable force feedback support for it.
+         Say Y here if you have a PantherLord/GreenAsia based game controller
+         or adapter and want to enable force feedback support for it.

 config THRUSTMASTER_FF
        bool "ThrustMaster FireStorm Dual Power 2 support (EXPERIMENTAL)"
Index: linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c
+++ linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c        2007-09-18 20:45:51.000000000 +0300
@@ -62,7 +62,8 @@
        { 0x46d, 0xca03, hid_lgff_init }, /* Logitech MOMO force wheel */
 #endif
 #ifdef CONFIG_PANTHERLORD_FF
-       { 0x810, 0x0001, hid_plff_init },
+       { 0x810, 0x0001, hid_plff_init }, /* "Twin USB Joystick" */
+       { 0xe8f, 0x0003, hid_plff_init }, /* "GreenAsia Inc.    USB Joystick     " */
 #endif
 #ifdef CONFIG_THRUSTMASTER_FF
        { 0x44f, 0xb300, hid_tmff_init },
Index: linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c
+++ linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c      2007-09-18 21:02:26.000000000 +0300
@@ -1,5 +1,15 @@
 /*
- *  Force feedback support for PantherLord USB/PS2 2in1 Adapter devices
+ *  Force feedback support for PantherLord/GreenAsia based devices
+ *
+ *  The devices are distributed under various names and the same USB device ID
+ *  can be used in both adapters and actual game controllers.
+ *
+ *  0810:0001 "Twin USB Joystick"
+ *   - tested with PantherLord USB/PS2 2in1 Adapter
+ *   - contains two reports, one for each port (HID_QUIRK_MULTI_INPUT)
+ *
+ *  0e8f:0003 "GreenAsia Inc.    USB Joystick     "
+ *   - tested with Köng Gaming gamepad
  *
  *  Copyright (c) 2007 Anssi Hannula <anssi.hannula@gmail.com>
  */
@@ -67,11 +77,11 @@
        struct input_dev *dev;
        int error;

-       /* The device contains 2 output reports (one for each
-          HID_QUIRK_MULTI_INPUT device), both containing 1 field, which
-          contains 4 ff00.0002 usages and 4 16bit absolute values.
+       /* The device contains one output report per physical device, all
+          containing 1 field, which contains 4 ff00.0002 usages and 4 16bit
+          absolute values.

-          The 2 input reports also contain a field which contains
+          The input reports also contain a field which contains
           8 ff00.0001 usages and 8 boolean values. Their meaning is
           currently unknown. */

@@ -122,8 +132,8 @@
                usbhid_submit_report(hid, plff->report, USB_DIR_OUT);
        }

-       printk(KERN_INFO "hid-plff: Force feedback for PantherLord USB/PS2 "
-              "2in1 Adapters by Anssi Hannula <anssi.hannula@gmail.com>\n");
+       printk(KERN_INFO "hid-plff: Force feedback for PantherLord/GreenAsia "
+              "devices by Anssi Hannula <anssi.hannula@gmail.com>\n");

        return 0;
 }


-- 
Anssi Hannula

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] HID: use hid-plff driver for GreenAsia 0e8f:0003 devices
  2007-09-18 18:23 [patch] HID: use hid-plff driver for GreenAsia 0e8f:0003 devices Anssi Hannula
@ 2007-09-19  9:57 ` Jiri Kosina
  2007-09-19 13:36   ` Anssi Hannula
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2007-09-19  9:57 UTC (permalink / raw)
  To: Anssi Hannula; +Cc: linux-input

[-- Attachment #1: Type: TEXT/PLAIN, Size: 503 bytes --]

On Tue, 18 Sep 2007, Anssi Hannula wrote:

> Add 0e8f:0003 into the list of devices supported by the hid-plff
> force feedback driver. These devices identify themselves as
> "GreenAsia Inc.    USB Joystick     " and can be either adapters or
> actual game controllers. The testing was done with a Köng Gaming
> gamepad.

Hi Anssi,

thanks a lot for your patch. Unfortunately, it is word-wrapped and 
whitespace-damaged, could you please respin it and resend it?

Thanks,

-- 
Jiri Kosina

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch] HID: use hid-plff driver for GreenAsia 0e8f:0003 devices
  2007-09-19  9:57 ` Jiri Kosina
@ 2007-09-19 13:36   ` Anssi Hannula
  0 siblings, 0 replies; 3+ messages in thread
From: Anssi Hannula @ 2007-09-19 13:36 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-input

Add 0e8f:0003 into the list of devices supported by the hid-plff
force feedback driver. These devices identify themselves as
"GreenAsia Inc.    USB Joystick     " and can be either adapters or
actual game controllers. The testing was done with a Köng Gaming
gamepad.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>

---

Index: linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig
+++ linux-2.6.23-rc6/drivers/hid/usbhid/Kconfig	2007-09-18 20:54:53.000000000 +0300
@@ -71,12 +71,12 @@
 	  force feedback.
 
 config PANTHERLORD_FF
-	bool "PantherLord USB/PS2 2in1 Adapter support"
+	bool "PantherLord/GreenAsia based device support"
 	depends on HID_FF
 	select INPUT_FF_MEMLESS if USB_HID
 	help
-	  Say Y here if you have a PantherLord USB/PS2 2in1 Adapter and want
-	  to enable force feedback support for it.
+	  Say Y here if you have a PantherLord/GreenAsia based game controller
+	  or adapter and want to enable force feedback support for it.
 
 config THRUSTMASTER_FF
 	bool "ThrustMaster FireStorm Dual Power 2 support (EXPERIMENTAL)"
Index: linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c
+++ linux-2.6.23-rc6/drivers/hid/usbhid/hid-ff.c	2007-09-18 20:45:51.000000000 +0300
@@ -62,7 +62,8 @@
 	{ 0x46d, 0xca03, hid_lgff_init }, /* Logitech MOMO force wheel */
 #endif
 #ifdef CONFIG_PANTHERLORD_FF
-	{ 0x810, 0x0001, hid_plff_init },
+	{ 0x810, 0x0001, hid_plff_init }, /* "Twin USB Joystick" */
+	{ 0xe8f, 0x0003, hid_plff_init }, /* "GreenAsia Inc.    USB Joystick     " */
 #endif
 #ifdef CONFIG_THRUSTMASTER_FF
 	{ 0x44f, 0xb300, hid_tmff_init },
Index: linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c
===================================================================
--- linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c
+++ linux-2.6.23-rc6/drivers/hid/usbhid/hid-plff.c	2007-09-18 21:02:26.000000000 +0300
@@ -1,5 +1,15 @@
 /*
- *  Force feedback support for PantherLord USB/PS2 2in1 Adapter devices
+ *  Force feedback support for PantherLord/GreenAsia based devices
+ *
+ *  The devices are distributed under various names and the same USB device ID
+ *  can be used in both adapters and actual game controllers.
+ *
+ *  0810:0001 "Twin USB Joystick"
+ *   - tested with PantherLord USB/PS2 2in1 Adapter
+ *   - contains two reports, one for each port (HID_QUIRK_MULTI_INPUT)
+ *
+ *  0e8f:0003 "GreenAsia Inc.    USB Joystick     "
+ *   - tested with Köng Gaming gamepad
  *
  *  Copyright (c) 2007 Anssi Hannula <anssi.hannula@gmail.com>
  */
@@ -67,11 +77,11 @@
 	struct input_dev *dev;
 	int error;
 
-	/* The device contains 2 output reports (one for each
-	   HID_QUIRK_MULTI_INPUT device), both containing 1 field, which
-	   contains 4 ff00.0002 usages and 4 16bit absolute values.
+	/* The device contains one output report per physical device, all
+	   containing 1 field, which contains 4 ff00.0002 usages and 4 16bit
+	   absolute values.
 
-	   The 2 input reports also contain a field which contains
+	   The input reports also contain a field which contains
 	   8 ff00.0001 usages and 8 boolean values. Their meaning is
 	   currently unknown. */
 
@@ -122,8 +132,8 @@
 		usbhid_submit_report(hid, plff->report, USB_DIR_OUT);
 	}
 
-	printk(KERN_INFO "hid-plff: Force feedback for PantherLord USB/PS2 "
-	       "2in1 Adapters by Anssi Hannula <anssi.hannula@gmail.com>\n");
+	printk(KERN_INFO "hid-plff: Force feedback for PantherLord/GreenAsia "
+	       "devices by Anssi Hannula <anssi.hannula@gmail.com>\n");
 
 	return 0;
 }


-- 
Anssi Hannula

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-09-19 13:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-18 18:23 [patch] HID: use hid-plff driver for GreenAsia 0e8f:0003 devices Anssi Hannula
2007-09-19  9:57 ` Jiri Kosina
2007-09-19 13:36   ` Anssi Hannula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).