From: Thomas Rohwer <tr@tng.de>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Problem with appletouch driver in Linux version 2.6.23-rc7
Date: Mon, 24 Sep 2007 15:22:16 +0200 [thread overview]
Message-ID: <46F7BA08.6000201@tng.de> (raw)
In-Reply-To: <1190638998.12782.0.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
Hello,
> could you please re-send the patch? I for some reason have yet to see
> it ...
here it is again, adressing also the comments from Dmitry.
Sincerely,
Thomas Rohwer
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1078 bytes --]
--- linux-2.6.23-rc7/drivers/input/mouse/appletouch.c 2007-09-20 01:01:13.000000000 +0200
+++ linux/drivers/input/mouse/appletouch.c 2007-09-24 15:15:56.000000000 +0200
@@ -328,6 +328,7 @@
{
int x, y, x_z, y_z, x_f, y_f;
int retval, i, j;
+ int key;
struct atp *dev = urb->context;
switch (urb->status) {
@@ -469,6 +470,9 @@
y = atp_calculate_abs(dev->xy_acc + ATP_XSENSORS, ATP_YSENSORS,
ATP_YFACT, &y_z, &y_f);
+ key= dev->data[dev->datalen - 1] & 1;
+ input_report_key(dev->input, BTN_LEFT, key);
+
if (x && y) {
if (dev->x_old != -1) {
x = (dev->x_old * 3 + x) >> 2;
@@ -505,7 +509,7 @@
the first touch unless reinitialised. Do so if it's been
idle for a while in order to avoid waking the kernel up
several hundred times a second */
- if (atp_is_geyser_3(dev)) {
+ if (atp_is_geyser_3(dev) && (!key)) {
dev->idlecount++;
if (dev->idlecount == 10) {
dev->valid = 0;
@@ -514,7 +518,6 @@
}
}
- input_report_key(dev->input, BTN_LEFT, dev->data[dev->datalen - 1] & 1);
input_sync(dev->input);
exit:
next prev parent reply other threads:[~2007-09-24 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 17:14 Problem with appletouch driver in Linux version 2.6.23-rc7 Thomas Rohwer
2007-09-24 12:40 ` Dmitry Torokhov
2007-09-24 12:49 ` Matthew Garrett
2007-09-24 13:03 ` Soeren Sonnenburg
2007-09-24 13:22 ` Thomas Rohwer [this message]
2007-09-26 19:56 ` Soeren Sonnenburg
2007-09-26 20:13 ` Dmitry Torokhov
2007-09-27 17:51 ` Soeren Sonnenburg
2007-09-27 21:08 ` Thomas Rohwer
2007-10-13 21:33 ` Soeren Sonnenburg
2007-10-13 21:44 ` Matthew Garrett
2007-10-15 13:09 ` Dmitry Torokhov
2007-09-24 13:10 ` Thomas Rohwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F7BA08.6000201@tng.de \
--to=tr@tng.de \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@nn7.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).