From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
Ian Campbell <ijc@hellion.org.uk>,
Gregory Clement <gregory.clement@free-electrons.com>,
tbm@cyrius.com
Subject: Re: [PATCH] ARM: Kirkwood: Add DT description of QNAP 419
Date: Wed, 15 Jan 2014 19:20:22 +0100 [thread overview]
Message-ID: <4773460.bSrjnYju7q@wuerfel> (raw)
In-Reply-To: <20140115174519.GE17530@lunn.ch>
On Wednesday 15 January 2014 18:45:19 Andrew Lunn wrote:
> > > But i'm also a little bit concerned by the "unique number" and this
> > > ending up in /dev/input/by-path/platform-gpio_keys.3-event. Is this
> > > path supposed to be stable? This unique number is not stable. An
> > > unwitting change to the DT could cause its value to change. Do we need
> > > to make it stable?
> > >
> >
> > One possibility would be to create an artificial bus in DT for all
> > gpio-keys devices, use #address-cells=<1> and #size-cells=<0>
> > for it, and give each device a unique reg property. Not sure if that
> > would be considered an elegant solution though.
>
> Hi Arnd
>
> Can i imply from your answer that you think
>
> /dev/input/by-path/platform-gpio_keys.3-event
>
> should be stable?
No, I have no idea whether it should be or not. I was just trying
to come up with a way to make it stable if that's desired.
> A quick look at udev rules seems to suggestion this is an issue for
> input/gpio-keys and maybe audio and video if there is a top level DT
> property collecting the different sub devices together for ASOC and
> V4L.
For some other subsystems, we have entries in /aliases/ to sort
them. Maybe that would work here to get a stable path independent
of the location in DT.
Arnd
prev parent reply other threads:[~2014-01-15 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389048557-16364-1-git-send-email-andrew@lunn.ch>
[not found] ` <1389174517.12612.87.camel@kazak.uk.xensource.com>
2014-01-11 21:04 ` [PATCH] ARM: Kirkwood: Add DT description of QNAP 419 Andrew Lunn
2014-01-15 16:36 ` Arnd Bergmann
2014-01-15 17:45 ` Andrew Lunn
2014-01-15 18:20 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4773460.bSrjnYju7q@wuerfel \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox