From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: multi-input quirk and skip output reports quirk Date: Fri, 04 Apr 2008 17:40:04 +0300 Message-ID: <47F63DC4.5030707@gmail.com> References: <47F21BA7.8030306@gmail.com> <47F2437C.6060203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from pne-smtpout4-sn1.fre.skanova.net ([81.228.11.168]:37657 "EHLO pne-smtpout4-sn1.fre.skanova.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbYDDOkG (ORCPT ); Fri, 4 Apr 2008 10:40:06 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: linux-input@vger.kernel.org Jiri Kosina wrote: > On Tue, 1 Apr 2008, Anssi Hannula wrote: > >>>> I've encountered another multi-input device that needs the skip output >>>> reports quirk (as it contains force feedback output reports), 0925:8866. >>>> However, maybe we should use another approach, dropping >>>> HID_QUIRK_SKIP_OUTPUT_REPORTS. Why not just *not* register the input >>>> device for that report in case the report didn't contain anything that >>>> was mapped by hidinput_configure_usage(), in hidinput_connect()? >>> as long as we still have the possibility to see the coming data in debug >>> mode, I don't have objection to that. >> Okay. >>> Are you going to make that patch? >> Not right now, maybe in a few weeks. > > I will meanwhile queue the patch below, ok? After the hidinput_connect() > is refactored to ignore devices for which the mappings haven't been > established, we could then remove all the devices for which we have > HID_QUIRK_SKIP_OUTPUT_REPORTS altogether. Ok. > BTW, do you happen to have any idea whether the Quad joypad needs this > quirk too? No, but I guess it is quite probable. > Thanks. > -- Anssi Hannula