* [PATCH] UCB1400 IRQ Probe fix
@ 2008-04-10 2:37 Vernon Sauder
2008-04-21 16:15 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Vernon Sauder @ 2008-04-10 2:37 UTC (permalink / raw)
To: linux-input; +Cc: Nicolas Pitre
The UCB1400 driver IRQ probe code fails to find an interrupt if all
the interrupts in the range 0-31 are nonprobe-able. This patch
removes the check of the return value so interrupts above 31 can be
detected.
This change may also be useful in drivers/mfd/ucb1x0-core.c but I
cannot test that on my hardware.
This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270
board.
Signed-off-by: Vernon Sauder <vsauder@inhand.com>
Acked-by: Nicolas Pitre <nico@marvell.com>
diff -ur linux.orig/drivers/input/touchscreen/ucb1400_ts.c
linux.new/drivers/input/touchscreen/ucb1400_ts.c
--- linux.orig/drivers/input/touchscreen/ucb1400_ts.c 2008-03-24
14:49:18.000000000 -0400
+++ linux.new/drivers/input/touchscreen/ucb1400_ts.c 2008-04-03
21:40:43.000000000 -0400
@@ -429,10 +429,6 @@
unsigned long mask, timeout;
mask = probe_irq_on();
- if (!mask) {
- probe_irq_off(mask);
- return -EBUSY;
- }
/* Enable the ADC interrupt. */
ucb1400_reg_write(ucb, UCB_IE_RIS, UCB_IE_ADC);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] UCB1400 IRQ Probe fix
@ 2008-04-16 17:43 Vernon Sauder
0 siblings, 0 replies; 3+ messages in thread
From: Vernon Sauder @ 2008-04-16 17:43 UTC (permalink / raw)
To: linux-input; +Cc: Nicolas Pitre
I am resending this because it didn't seem to get to the list.
---
The UCB1400 driver IRQ probe code fails to find an interrupt if all
the interrupts in the range 0-31 are nonprobe-able. This patch
removes the check of the return value so interrupts above 31 can be
detected.
This change may also be useful in drivers/mfd/ucb1x0-core.c but I
cannot test that on my hardware.
This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270
board.
Signed-off-by: Vernon Sauder <vsauder@inhand.com>
Acked-by: Nicolas Pitre <nico@marvell.com>
---
diff -ur linux.orig/drivers/input/touchscreen/ucb1400_ts.c
linux.new/drivers/input/touchscreen/ucb1400_ts.c
--- linux.orig/drivers/input/touchscreen/ucb1400_ts.c 2008-03-24
14:49:18.000000000 -0400
+++ linux.new/drivers/input/touchscreen/ucb1400_ts.c 2008-04-03
21:40:43.000000000 -0400
@@ -429,10 +429,6 @@
unsigned long mask, timeout;
mask = probe_irq_on();
- if (!mask) {
- probe_irq_off(mask);
- return -EBUSY;
- }
/* Enable the ADC interrupt. */
ucb1400_reg_write(ucb, UCB_IE_RIS, UCB_IE_ADC);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UCB1400 IRQ Probe fix
2008-04-10 2:37 Vernon Sauder
@ 2008-04-21 16:15 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2008-04-21 16:15 UTC (permalink / raw)
To: Vernon Sauder; +Cc: linux-input, Nicolas Pitre
On Wed, Apr 09, 2008 at 10:37:19PM -0400, Vernon Sauder wrote:
> The UCB1400 driver IRQ probe code fails to find an interrupt if all
> the interrupts in the range 0-31 are nonprobe-able. This patch
> removes the check of the return value so interrupts above 31 can be
> detected.
>
> This change may also be useful in drivers/mfd/ucb1x0-core.c but I
> cannot test that on my hardware.
>
> This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270
> board.
>
> Signed-off-by: Vernon Sauder <vsauder@inhand.com>
> Acked-by: Nicolas Pitre <nico@marvell.com>
>
Applied, thank you Vernon.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-21 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-16 17:43 [PATCH] UCB1400 IRQ Probe fix Vernon Sauder
-- strict thread matches above, loose matches on Subject: below --
2008-04-10 2:37 Vernon Sauder
2008-04-21 16:15 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).