linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Gruber <lists.mg@googlemail.com>, linux-input@vger.kernel.org
Subject: Re: xpad - Rename buttons to avoid conflict with mouse input
Date: Wed, 16 Apr 2008 21:56:12 +0300	[thread overview]
Message-ID: <48064BCC.5020203@gmail.com> (raw)
In-Reply-To: <20080416143149.ZZRA012@mailhub.coreip.homeip.net>

Dmitry Torokhov wrote:
> On Wed, Apr 16, 2008 at 07:49:33PM +0300, Anssi Hannula wrote:
>> Michael Gruber wrote:
>>> From: Michael Gruber <lists.mg@googlemail.com>
>>>
>>> BTN_LEFT, BTN_RIGHT and BTN_BACK are listed as mouse buttons according to
>>> input.h. Rename them to make sure they do not interfere with mouse input.
>>>
>>> Signed-off-by: Michael Gruber <lists.mg@googlemail.com>
>>>
>>> ---
>>>
>>> When I set up the driver to use MAP_DPAD_TO_BUTTONS the controller starts
>>> acting as mouse. Touching the d-pad issues left and right mouse click events
>>> and the back button acts like one of my other mouse buttons.
>> Patch seems correct to me.
>>
>> Acked-by: Anssi Hannula <anssi.hannula@gmail.com>
>>
> 
> The original author of d-pad mode did that so the pad withh work
> with stepmania. If left/right/0/1 are the defaults used there
> we might break existing setups...

With a quick test there seem to be no default mappings for game
controllers, but they are manually defined.

IMO having to redefine keys after a major kernel upgrade is ok, and
certainly a lesser trouble than having dancepad directionals act as
mouse buttons.

> Do you know of other applications
> using dance pads?

Nope.

-- 
Anssi Hannula

      reply	other threads:[~2008-04-16 18:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-15 10:13 xpad - Rename buttons to avoid conflict with mouse input Michael Gruber
2008-04-16 16:49 ` Anssi Hannula
2008-04-16 18:34   ` Dmitry Torokhov
2008-04-16 18:56     ` Anssi Hannula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48064BCC.5020203@gmail.com \
    --to=anssi.hannula@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=lists.mg@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).