From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jiri Kosina <jikos@kernel.org>, Bastien Nocera <hadess@hadess.net>
Cc: "Filipe Laíns" <lains@riseup.net>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thorsten Leemhuis" <regressions@leemhuis.info>
Subject: [PATCH v1 1/2] HID: generic: Add ->match() check to __check_hid_generic()
Date: Wed, 07 Dec 2022 10:11:50 +0100 [thread overview]
Message-ID: <4809717.31r3eYUQgx@kreacher> (raw)
In-Reply-To: <5647715.DvuYhMxLoT@kreacher>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Some special HID drivers (for example, hid-logitech-hidpp) use ->match()
callbacks to reject specific devices that otherwise would match the
driver's device ID list, with the expectation that those devices will
be handled by some other drivers. However, this doesn't work if
hid-generic is expected to bind to the given device, because its
->match() callback, hid_generic_match(), rejects all devices that match
device ID lists of the other HID drivers regardless of what is returned
by the other drivers' ->match() callbacks.
To make it work, amend the function used by hid_generic_match() for
checking an individual driver, __check_hid_generic(), with a check
involving the given driver's ->match() callback, so 0 is returned
when that callback rejects the device in question.
Fixes: 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/hid/hid-generic.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Index: linux-pm/drivers/hid/hid-generic.c
===================================================================
--- linux-pm.orig/drivers/hid/hid-generic.c
+++ linux-pm/drivers/hid/hid-generic.c
@@ -31,7 +31,13 @@ static int __check_hid_generic(struct de
if (hdrv == &hid_generic)
return 0;
- return hid_match_device(hdev, hdrv) != NULL;
+ if (!hid_match_device(hdev, hdrv))
+ return 0;
+
+ if (hdrv->match)
+ return hdrv->match(hdev, false);
+
+ return 1;
}
static bool hid_generic_match(struct hid_device *hdev,
next prev parent reply other threads:[~2022-12-07 9:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 14:58 [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) Rafael J. Wysocki
2022-12-07 8:58 ` Rafael J. Wysocki
2022-12-07 9:07 ` Bastien Nocera
2022-12-07 9:04 ` Bastien Nocera
2022-12-07 9:16 ` Rafael J. Wysocki
2022-12-07 9:36 ` Rafael J. Wysocki
2022-12-07 9:58 ` Bastien Nocera
2022-12-07 10:07 ` Rafael J. Wysocki
2022-12-07 10:50 ` Bastien Nocera
2022-12-07 11:07 ` Rafael J. Wysocki
2022-12-07 17:19 ` Bastien Nocera
2022-12-07 17:44 ` Rafael J. Wysocki
2022-12-08 15:20 ` Bastien Nocera
2022-12-13 16:14 ` Bastien Nocera
2022-12-15 15:09 ` Rafael J. Wysocki
2022-12-07 9:10 ` [PATCH v1 0/2] HID: Fix regression resulting from commit 532223c8ac57 Rafael J. Wysocki
2022-12-07 9:11 ` Rafael J. Wysocki [this message]
2022-12-07 9:27 ` [PATCH v1 1/2] HID: generic: Add ->match() check to __check_hid_generic() Benjamin Tissoires
2022-12-07 9:54 ` Rafael J. Wysocki
2022-12-07 9:12 ` [PATCH v1 2/2] HID: logitech-hidpp: Add Bluetooth Mouse M336/M337/M535 to unhandled_hidpp_devices[] Rafael J. Wysocki
2022-12-07 9:29 ` Bastien Nocera
2022-12-07 9:47 ` Rafael J. Wysocki
2022-12-07 9:59 ` Bastien Nocera
2022-12-07 10:05 ` Benjamin Tissoires
2022-12-07 10:11 ` Rafael J. Wysocki
2022-12-07 10:19 ` Jiri Kosina
2022-12-07 12:43 ` Bastien Nocera
2022-12-07 13:00 ` Rafael J. Wysocki
2022-12-07 13:24 ` Benjamin Tissoires
2022-12-07 13:39 ` Rafael J. Wysocki
2022-12-07 14:24 ` Bastien Nocera
2022-12-08 13:32 ` Benjamin Tissoires
2022-12-07 9:48 ` Benjamin Tissoires
2022-12-07 9:59 ` Bastien Nocera
2022-12-08 7:03 ` [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) #forregzbot Thorsten Leemhuis
2022-12-09 6:34 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4809717.31r3eYUQgx@kreacher \
--to=rjw@rjwysocki.net \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).