From: Jiri Slaby <jirislaby@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
anssi.hannula@gmail.com, akpm@linux-foundation.org,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 2/9] HID: make a bus from hid code
Date: Wed, 14 May 2008 11:30:23 +0200 [thread overview]
Message-ID: <482AB12F.20106@gmail.com> (raw)
In-Reply-To: <1210547158.16390.28.camel@violet.holtmann.net>
Hi!
Marcel Holtmann napsal(a):
>> +static struct hid_driver hid_generic_bt = {
>> + .name = "hid-generic-bt",
>> + .id_table = hid_generic_bt_ids,
>> +};
>
> And this one to hidp_driver instead of hid_generic_bt.
>
> Also the name "hid-generic-bt" is not okay. Call it "hidp" since that is
> the driver name. An alternative would be "hid-bluetooth". I don't like
> the "generic" part and we never used the shortcut "bt" in any sysfs
> visible file.
Thanks for comments, I fixed all those except this one. The generic- word is
tested in the core to recognize generic drivers which bind non-blacklisted
devices and are handled separately. Anyway I've renamed them to
generic-bluetooth and generic-usb instead of hid-generic-{bt,usb}.
I think the generic word in the driver name is OK, so that one ordinary user
can see, my device is handled by the generic driver without special
processing. Would you rather see some flag or something?
next prev parent reply other threads:[~2008-05-14 9:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 20:00 [PATCH 1/9] modpost: add support for hid Jiri Slaby
2008-05-11 20:00 ` [PATCH 2/9] HID: make a bus from hid code Jiri Slaby
2008-05-11 20:00 ` [PATCH 3/9] HID: hid, make parsing event driven Jiri Slaby
2008-05-11 20:00 ` [PATCH 4/9] HID: move ids into separate file Jiri Slaby
2008-05-11 20:00 ` [PATCH 5/9] HID: move usage input mapping to hid.h Jiri Slaby
2008-05-11 20:00 ` [PATCH 6/9] HID: move logitech report quirks Jiri Slaby
2008-05-11 20:00 ` [PATCH 7/9] HID: move ignore quirks Jiri Slaby
2008-05-11 20:00 ` [PATCH 8/9] HID: move apple quirks Jiri Slaby
2008-05-11 20:00 ` [PATCH 9/9] HID: add compat support Jiri Slaby
2008-05-11 20:48 ` Sam Ravnborg
2008-05-11 21:07 ` Jiri Slaby
2008-05-11 21:18 ` Sam Ravnborg
2008-05-12 7:19 ` Jiri Slaby
2008-05-11 23:18 ` Marcel Holtmann
2008-05-11 23:15 ` [PATCH 8/9] HID: move apple quirks Marcel Holtmann
2008-05-11 23:20 ` [PATCH 3/9] HID: hid, make parsing event driven Marcel Holtmann
2008-05-14 9:34 ` Jiri Slaby
2008-05-14 12:08 ` Jiri Kosina
2008-05-11 23:05 ` [PATCH 2/9] HID: make a bus from hid code Marcel Holtmann
2008-05-14 9:30 ` Jiri Slaby [this message]
2008-05-15 9:11 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482AB12F.20106@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anssi.hannula@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).