From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH 2/9] HID: make a bus from hid code Date: Wed, 14 May 2008 11:30:23 +0200 Message-ID: <482AB12F.20106@gmail.com> References: <1210536043-19812-1-git-send-email-jirislaby@gmail.com> <1210536043-19812-2-git-send-email-jirislaby@gmail.com> <1210547158.16390.28.camel@violet.holtmann.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from fk-out-0910.google.com ([209.85.128.191]:1743 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbYENJa1 (ORCPT ); Wed, 14 May 2008 05:30:27 -0400 Received: by fk-out-0910.google.com with SMTP id 18so2647239fkq.5 for ; Wed, 14 May 2008 02:30:26 -0700 (PDT) In-Reply-To: <1210547158.16390.28.camel@violet.holtmann.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marcel Holtmann Cc: Jiri Kosina , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, anssi.hannula@gmail.com, akpm@linux-foundation.org, Jiri Slaby Hi! Marcel Holtmann napsal(a): >> +static struct hid_driver hid_generic_bt = { >> + .name = "hid-generic-bt", >> + .id_table = hid_generic_bt_ids, >> +}; > > And this one to hidp_driver instead of hid_generic_bt. > > Also the name "hid-generic-bt" is not okay. Call it "hidp" since that is > the driver name. An alternative would be "hid-bluetooth". I don't like > the "generic" part and we never used the shortcut "bt" in any sysfs > visible file. Thanks for comments, I fixed all those except this one. The generic- word is tested in the core to recognize generic drivers which bind non-blacklisted devices and are handled separately. Anyway I've renamed them to generic-bluetooth and generic-usb instead of hid-generic-{bt,usb}. I think the generic word in the driver name is OK, so that one ordinary user can see, my device is handled by the generic driver without special processing. Would you rather see some flag or something?