From: Kwangwoo Lee <kwangwoo.lee@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thierry Reding <thierry.reding@avionic-design.de>
Cc: Trilok Soni <soni.trilok@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: [PATCH 2/2] Input: tsc2007: do I2C transfers in non-interrupt context
Date: Mon, 11 May 2009 20:44:00 +0900 [thread overview]
Message-ID: <483a38b80905110444n7d55b967j70cf2639dff1c706@mail.gmail.com> (raw)
>From d5de0d22109de7564f9bf1df688acbe6b18f41db Mon Sep 17 00:00:00 2001
From: Kwangwoo Lee <kwangwoo.lee@gmail.com>
Date: Mon, 11 May 2009 20:05:50 +0900
Subject: [PATCH 2/2] Input: tsc2007: do I2C transfers in non-interrupt context.
This patch enhances pointer movements much smoother.
The original patch is written by Thierry.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Kwangwoo Lee <kwangwoo.lee@gmail.com>
---
drivers/input/touchscreen/tsc2007.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/tsc2007.c
b/drivers/input/touchscreen/tsc2007.c
index 948e167..03bbe58 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -70,6 +70,7 @@ struct ts_event {
struct tsc2007 {
struct input_dev *input;
char phys[32];
+ struct work_struct work;
struct hrtimer timer;
struct ts_event tc;
@@ -173,6 +174,9 @@ static void tsc2007_send_event(void *tsc)
dev_dbg(&ts->client->dev, "point(%4d,%4d), pressure (%4u)\n",
x, y, rt);
+ } else {
+ if (!ts->pendown)
+ ts->pendown = 1;
}
hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_PERIOD),
@@ -197,6 +201,13 @@ static int tsc2007_read_values(struct tsc2007 *tsc)
return 0;
}
+static void tsc2007_work(struct work_struct *work)
+{
+ struct tsc2007 *ts = container_of(work, struct tsc2007, work);
+ tsc2007_read_values(ts);
+ tsc2007_send_event(ts);
+}
+
static enum hrtimer_restart tsc2007_timer(struct hrtimer *handle)
{
struct tsc2007 *ts = container_of(handle, struct tsc2007, timer);
@@ -218,9 +229,7 @@ static enum hrtimer_restart tsc2007_timer(struct
hrtimer *handle)
} else {
/* pen is still down, continue with the measurement */
dev_dbg(&ts->client->dev, "pen is still down\n");
-
- tsc2007_read_values(ts);
- tsc2007_send_event(ts);
+ schedule_work(&ts->work);
}
spin_unlock_irqrestore(&ts->lock, flags);
@@ -253,7 +262,7 @@ static int tsc2007_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct tsc2007 *ts;
- struct tsc2007_platform_data *pdata = pdata = client->dev.platform_data;
+ struct tsc2007_platform_data *pdata = client->dev.platform_data;
struct input_dev *input_dev;
int err;
@@ -280,6 +289,7 @@ static int tsc2007_probe(struct i2c_client *client,
hrtimer_init(&ts->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
ts->timer.function = tsc2007_timer;
+ INIT_WORK(&ts->work, tsc2007_work);
spin_lock_init(&ts->lock);
--
1.5.6.5
next reply other threads:[~2009-05-11 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 11:44 Kwangwoo Lee [this message]
2009-05-11 15:38 ` [PATCH 2/2] Input: tsc2007: do I2C transfers in non-interrupt context Dmitry Torokhov
2009-05-11 15:41 ` Dmitry Torokhov
2009-05-12 1:40 ` Kwangwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483a38b80905110444n7d55b967j70cf2639dff1c706@mail.gmail.com \
--to=kwangwoo.lee@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).