[PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[Kwangwoo Lee]

Hi Dmitry,

This patch contains a trivial removal and check the existence of a
platform specific function.

Regards,
Kwangwoo Lee

>From bc18ba8c71027ca58d1242149eee9919bdaa069b Mon Sep 17 00:00:00 2001
From: Kwangwoo Lee <kwangwoo.lee@gmail.com>
Date: Fri, 15 May 2009 13:43:55 +0900
Subject: [PATCH] Input: tsc2007: remove useless code and check a
necessary function is provided or not.

Remove a useless code and check a necessary function is implemented or not.
The platform codes must provide get_pendown_state() to work properly.

Signed-off-by: Kwangwoo Lee <kwangwoo.lee@gmail.com>
---
 drivers/input/touchscreen/tsc2007.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007.c
b/drivers/input/touchscreen/tsc2007.c
index 948e167..da35adb 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -253,11 +253,11 @@ static int tsc2007_probe(struct i2c_client *client,
 			const struct i2c_device_id *id)
 {
 	struct tsc2007 *ts;
-	struct tsc2007_platform_data *pdata = pdata = client->dev.platform_data;
+	struct tsc2007_platform_data *pdata = client->dev.platform_data;
 	struct input_dev *input_dev;
 	int err;

-	if (!pdata) {
+	if (!pdata || !pdata->get_pendown_state) {
 		dev_err(&client->dev, "platform data is required!\n");
 		return -EINVAL;
 	}
-- 
1.5.6.5

Re: [PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[Manuel Lauss]

On Fri, May 15, 2009 at 02:47:12PM +0900, Kwangwoo Lee wrote:
> --- a/drivers/input/touchscreen/tsc2007.c
> +++ b/drivers/input/touchscreen/tsc2007.c
> @@ -253,11 +253,11 @@ static int tsc2007_probe(struct i2c_client *client,
>  			const struct i2c_device_id *id)
>  {
>  	struct tsc2007 *ts;
> -	struct tsc2007_platform_data *pdata = pdata = client->dev.platform_data;
> +	struct tsc2007_platform_data *pdata = client->dev.platform_data;

This change is already in a previous patch of yours.
(http://www.spinics.net/lists/linux-input/msg03404.html)

Manuel Lauss

Re: [PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[Kwangwoo Lee]

On Fri, May 15, 2009 at 4:26 PM, Manuel Lauss
<mano@roarinelk.homelinux.net> wrote:
> On Fri, May 15, 2009 at 02:47:12PM +0900, Kwangwoo Lee wrote:
>> --- a/drivers/input/touchscreen/tsc2007.c
>> +++ b/drivers/input/touchscreen/tsc2007.c
>> @@ -253,11 +253,11 @@ static int tsc2007_probe(struct i2c_client *client,
>>                       const struct i2c_device_id *id)
>>  {
>>       struct tsc2007 *ts;
>> -     struct tsc2007_platform_data *pdata = pdata = client->dev.platform_data;
>> +     struct tsc2007_platform_data *pdata = client->dev.platform_data;
>
> This change is already in a previous patch of yours.
> (http://www.spinics.net/lists/linux-input/msg03404.html)

Yes, I know.
The patch has a bit different subject. And it is requried to review more.
This patch just includes small fix and check.

>
> Manuel Lauss
>

-- 
Kwangwoo Lee <kwangwoo.lee@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[Dmitry Torokhov]

On Fri, May 15, 2009 at 02:47:12PM +0900, Kwangwoo Lee wrote:
> Hi Dmitry,
> 
> This patch contains a trivial removal and check the existence of a
> platform specific function.
> 

Applied, thanks.

-- 
Dmitry