From: Bastien Nocera <hadess@hadess.net>
To: Andreas Bergmeier <abergmeier@gmx.net>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
USB mailing list <linux-usb@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: PATCH: Simplify hidpp_send_rap_command_sync calls
Date: Mon, 14 Nov 2022 15:20:18 +0100 [thread overview]
Message-ID: <487b7e01e0847411e5893a8341bf027cc9d8c4bf.camel@hadess.net> (raw)
In-Reply-To: <4b871484-b19-95b8-f973-bfebcb5348ab@9300>
On Thu, 2022-11-10 at 15:47 +0100, Andreas Bergmeier wrote:
> Inside function, report_id might get overwritten.
> Only REPORT_ID_HIDPP_SHORT is ever passed in.
> So there seems to be no point in passing report_id in the first
> place.
> Just directly evaluate which report_id to use in the function itself.
Looks good.
Reviewed-by: Bastien Nocera <hadess@hadess.net>
prev parent reply other threads:[~2022-11-14 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 14:47 PATCH: Simplify hidpp_send_rap_command_sync calls Andreas Bergmeier
2022-11-11 6:07 ` Greg KH
2022-11-14 14:20 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487b7e01e0847411e5893a8341bf027cc9d8c4bf.camel@hadess.net \
--to=hadess@hadess.net \
--cc=abergmeier@gmx.net \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).