From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrik Rydberg Subject: Re: [PATCH] hid: wellspring device quirks Date: Tue, 22 Jul 2008 15:31:42 +0200 Message-ID: <4885E13E.1010607@euromail.se> References: <1215963466.12757.0.camel@alnilam> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:41995 "EHLO ch-smtp02.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbYGVNb6 (ORCPT ); Tue, 22 Jul 2008 09:31:58 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , robfitz@273k.net, akpm@osdl.org, Vojtech Pavlik , dmonakhov@openvz.org Jiri Kosina wrote: > On Sun, 13 Jul 2008, Henrik Rydberg wrote: > >> This patch adds the HID_QUIRK_IGNORE_MOUSE quirk for the Apple USB >> multitouch devices based on BCM5974, aka Wellspring. These devices >> will instead be picked up by the new bcm5974 driver. > > Hi Henrik, > > is the mouse not working at all with standard HID driver? > Yes, it is working out-of-the-box, only poorly. > I'd prefer to postpone merging this patch until bcm5974 hits mainline if > the device works in a limited way with standard HID driver, so that we > don't introduce regression. > Absolutely, this patch should be applied together with the bcm5974 driver, or not be applied. The driver patch is here: http://userweb.kernel.org/~akpm/mmotm/broken-out/input-bcm5974-055-smoother-motion-irq-simplification.patch > If the device doesn't work with HID driver at all though, it is probably > perfectly fine to merge it right away. Please let me know, I have no > knowledge about this particular device. It is fine to leave it, but I would of course prefer to have the driver included together with this patch. Thanks! Henrik Rydberg