From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org,
Anssi Hannula <anssi.hannula@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] HID: move pantherlord FF processing
Date: Thu, 18 Sep 2008 10:41:08 +0200 [thread overview]
Message-ID: <48D21424.9030807@gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0809171900030.19221@pegasus.suse.cz>
On 09/17/2008 07:03 PM, Jiri Kosina wrote:
> On Thu, 4 Sep 2008, Jiri Slaby wrote:
>
>> Move the force feedback precessing into a separate module.
>>
>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 0784a09..a4d9695 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -373,6 +373,8 @@
>> #define USB_DEVICE_ID_QUAD_USB_JOYPAD 0x8800
>> #define USB_DEVICE_ID_DUAL_USB_JOYPAD 0x8866
>>
>> +#define USB_VENDOR_ID_GREENASIA 0x0e8f
>> +
>> #define USB_VENDOR_ID_WISEGROUP_LTD 0x6666
>> #define USB_VENDOR_ID_WISEGROUP_LTD2 0x6677
>> #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>
> Could we please preserve alphabetical ordering in hid-ids.h file?
Oops, sorry for that, I tried to sort it numerically not noticing it's sorted
alphabetically.
> Otherwise the series looks good to me, and Anssi didn't complain as well.
> Could you please rebase it on top of the current HID tree, fix the
> ordering, and send it to me again, I will apply it?
No problem.
Thanks.
next prev parent reply other threads:[~2008-09-18 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 12:59 [PATCH 1/5] HID: move pantherlord FF processing Jiri Slaby
2008-09-04 12:59 ` [PATCH 2/5] HID: move thrustmaster " Jiri Slaby
2008-09-04 12:59 ` [PATCH 3/5] HID: move zeroplus " Jiri Slaby
2008-09-04 12:59 ` [PATCH 4/5] HID: remove hid-ff Jiri Slaby
2008-09-04 12:59 ` [PATCH 5/5] HID: convert to dev_* prints Jiri Slaby
2008-09-17 17:03 ` [PATCH 1/5] HID: move pantherlord FF processing Jiri Kosina
2008-09-18 8:41 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-18 8:57 Jiri Slaby
2008-09-18 8:57 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D21424.9030807@gmail.com \
--to=jirislaby@gmail.com \
--cc=anssi.hannula@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).