From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: Sleeping inside spinlock in force feedback input event code Date: Sat, 04 Oct 2008 14:33:03 +0300 Message-ID: <48E7546F.3010307@gmail.com> References: <4868e2410806150157o5b290bf7kaccdeb2faf5057d6@mail.gmail.com> <485540A6.1050306@gmail.com> <4868e2410806151023j67ceea16pe1c5ad8ab9a8e122@mail.gmail.com> <4855507E.4030201@gmail.com> <4868e2410806151036o1a1652d8y8bf8432e3c6c0d06@mail.gmail.com> <4868e2410806151036r6d96a840v41b8ee745041db35@mail.gmail.com> <4868e2410806151105v3fec88a1qa439e2cc1423bc6a@mail.gmail.com> <48556723.2090204@gmail.com> <20080616143112.ZZRA012@mailhub.coreip.homeip.net> <485807F4.3010903@gmail.com> <20080617153423.ZZRA012@mailhub.coreip.homeip.net> <48581857.2080906@gmail.com> <4866E804.3000603@gmail.com> <4883474D.6080602@gmail.com> <48D55D8B.4070904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mta-out.inet.fi ([195.156.147.13]:38181 "EHLO kirsi2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbYJDLdI (ORCPT ); Sat, 4 Oct 2008 07:33:08 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Dmitry Torokhov , linux-input@vger.kernel.org, James Carthew Jiri Kosina wrote: > On Sat, 20 Sep 2008, Anssi Hannula wrote: > >>> I like the previous generic approach more. It looks correct to me, but >>> you marked the patch as untested when you were sending it. Is this >>> still the case? >> I've done some more testing and it seems to be working fine. > > Great, thanks! Could you please rebase the patch against current state of > my HID tree (as in linux-next, -mm, or just the 'mm' branch of hid.git on > kernel.org), and send it to me, I will merge it right away? > > There were some changes in the code due to hidbus getting finally merged, > but it should be rather trivial to solve. AFAICS no changes are needed, it applies to hid.git#mm fine. -- Anssi Hannula