From: Jiri Slaby <jirislaby@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Jiri Kosina <jikos@jikos.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: cleanup of hiddev
Date: Tue, 04 Nov 2008 16:17:49 +0100 [thread overview]
Message-ID: <4910679D.4010406@gmail.com> (raw)
In-Reply-To: <200811041612.22282.oliver@neukum.org>
Oliver Neukum napsal(a):
> Am Dienstag, 4. November 2008 16:00:06 schrieb Alan Stern:
>> On Tue, 4 Nov 2008, Oliver Neukum wrote:
>>
>>> Am Montag, 3. November 2008 20:58:11 schrieb Jiri Slaby:
>>>> Hi.
>>>>
>>>>> this is the cleanup of hiddev against current vanilla. What do you think?
>>>> See my comments below.
>>> Hi,
>>>
>>> there still is a race of disconnect() with ioctl(). It seems like that
>>> code still operates under the assumption that both methods take
>>> BKL. Do you prefer a conservative fix with selective application of BKL
>>> or introduction of a new mutex?
>> It's none of my business... but IMO we should try to move away from the
>> BKL as much as possible.
>
> This is true but hiddev is in a sense legacy code which should be replaced
> with hidraw, so I tend to fix it conservatively.
Jiri K. is off for few days, I'm not responsible for the HID layer, he is, I
would let him to decide ;).
next prev parent reply other threads:[~2008-11-04 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 16:31 cleanup of hiddev Oliver Neukum
2008-11-03 19:58 ` Jiri Slaby
[not found] ` <490F57D3.6060503-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-04 12:17 ` Oliver Neukum
[not found] ` <200811041317.40482.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-04 15:19 ` Jiri Slaby
[not found] ` <4910681D.6020701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-04 15:29 ` Oliver Neukum
2008-11-04 15:33 ` Jiri Slaby
2008-11-04 17:56 ` Oliver Neukum
[not found] ` <200811041856.47950.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-04 20:34 ` Jiri Slaby
2008-11-04 22:51 ` Oliver Neukum
2008-11-04 22:57 ` Jiri Slaby
2008-11-04 22:59 ` Oliver Neukum
2008-11-04 14:19 ` Oliver Neukum
2008-11-04 15:00 ` Alan Stern
2008-11-04 15:12 ` Oliver Neukum
2008-11-04 15:17 ` Jiri Slaby [this message]
2008-11-04 13:07 ` Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2008-11-05 11:52 Oliver Neukum
[not found] ` <200811051252.40133.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-05 12:03 ` Jiri Slaby
2008-11-11 23:53 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4910679D.4010406@gmail.com \
--to=jirislaby@gmail.com \
--cc=jikos@jikos.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).