From: Jiri Slaby <jirislaby@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jikos@jikos.cz>
Subject: Re: locking in hidraw
Date: Tue, 04 Nov 2008 21:36:29 +0100 [thread overview]
Message-ID: <4910B24D.2020700@gmail.com> (raw)
In-Reply-To: <200811041534.38166.oliver@neukum.org>
Ccing jikos.
Oliver Neukum napsal(a):
> Hi,
>
> in this code:
>
> mutex_lock(&list->read_mutex);
>
> if (list->head == list->tail) {
> add_wait_queue(&list->hidraw->wait, &wait);
> set_current_state(TASK_INTERRUPTIBLE);
>
> it would make more sense to lock the mutex interruptable so all
> tasks sleep the same way. Is this intentional?
next prev parent reply other threads:[~2008-11-04 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 14:34 locking in hidraw Oliver Neukum
2008-11-04 20:36 ` Jiri Slaby [this message]
2008-11-12 14:39 ` Jiri Kosina
2008-11-12 14:51 ` Oliver Neukum
2008-12-01 10:07 ` Jiri Kosina
2008-12-08 9:08 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4910B24D.2020700@gmail.com \
--to=jirislaby@gmail.com \
--cc=jikos@jikos.cz \
--cc=linux-input@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).