From: Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>
To: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jiri Kosina <jikos-wDf7oJUeT2I@public.gmane.org>
Subject: Re: cleanup of hiddev
Date: Wed, 05 Nov 2008 13:03:47 +0100 [thread overview]
Message-ID: <49118BA3.90004@suse.cz> (raw)
In-Reply-To: <200811051252.40133.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
On 11/05/2008 12:52 PM, Oliver Neukum wrote:
> @@ -334,35 +354,45 @@ static ssize_t hiddev_read(struct file * file, char __user * buffer, size_t coun
> break;
> }
>
> + /* let O_NONBLOCK tasks run */
> + mutex_unlock(&list->thread_lock);
> schedule();
> + if (mutex_lock_interruptible(&list->thread_lock))
> + return -ERESTARTSYS;
This should be EINTR, since the code potentially moved with tail and no rollback
is performed.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-05 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 11:52 cleanup of hiddev Oliver Neukum
[not found] ` <200811051252.40133.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-05 12:03 ` Jiri Slaby [this message]
2008-11-11 23:53 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2008-11-03 16:31 Oliver Neukum
2008-11-03 19:58 ` Jiri Slaby
2008-11-04 13:07 ` Oliver Neukum
[not found] ` <490F57D3.6060503-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-04 12:17 ` Oliver Neukum
[not found] ` <200811041317.40482.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-04 15:19 ` Jiri Slaby
[not found] ` <4910681D.6020701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-04 15:29 ` Oliver Neukum
2008-11-04 15:33 ` Jiri Slaby
2008-11-04 17:56 ` Oliver Neukum
[not found] ` <200811041856.47950.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-11-04 20:34 ` Jiri Slaby
2008-11-04 22:51 ` Oliver Neukum
2008-11-04 22:57 ` Jiri Slaby
2008-11-04 22:59 ` Oliver Neukum
2008-11-04 14:19 ` Oliver Neukum
2008-11-04 15:00 ` Alan Stern
2008-11-04 15:12 ` Oliver Neukum
2008-11-04 15:17 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49118BA3.90004@suse.cz \
--to=jslaby-alswssmvlrq@public.gmane.org \
--cc=jikos-wDf7oJUeT2I@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).