From: Jiri Slaby <jirislaby@gmail.com>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: Tobias Lorenz <tobias.lorenz@gmx.net>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: next: 6a13378a5 (Don't allow KWorld radio...) is broken
Date: Wed, 12 Nov 2008 21:37:36 +0100 [thread overview]
Message-ID: <491B3E90.5020307@gmail.com> (raw)
Hi guys,
The commit below is apparently wrong. Maybe you CCed HID maintainer, however
linux-input didn't get the message, or at least I can't find it anywhere.
There is a difference between hid_blacklist and hid_ignore_list. One forbids
generic hid driver to bind the device, while the other forces usbhid to release
the device and move hands away from it.
You picked up the former, which is wrong. I wonder if you were so lucky that you
didn't hit it. Care to send a fixup with proper CCs?
Thanks.
commit 6a13378a56ce06afca9db75f3d4e663fba5f0992
Author: Alexey Klimov <klimov.linux@gmail.com>
Date: Sun Oct 19 20:10:13 2008 -0300
V4L/DVB (9337a): HID: Don't allow KWorld radio fm700 be handled by usb hid d
rivers
This device is already handled by radio-si470x driver, and we
therefore want usbhid to ignore it.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Acked-by: Tobias Lorenz <tobias.lorenz@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 1903e75..d3671b4 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1265,6 +1265,7 @@ static const struct hid_device_id hid_blacklist[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) },
{ HID_USB_DEVICE(USB_VENDOR_ID_GENERIC_13BA, USB_DEVICE_ID_GENERIC_13BA_
KBD_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE)
},
+ { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700)
},
{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2
) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEY
BOARD) },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER)
},
next reply other threads:[~2008-11-12 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 20:37 Jiri Slaby [this message]
2008-11-13 0:33 ` next: 6a13378a5 (Don't allow KWorld radio...) is broken Jiri Kosina
2008-11-13 2:44 ` [PATCH 1/2] hid: fix kworld fm700 radio hidquirks Alexey Klimov
2008-11-13 2:44 ` [PATCH 2/2] hid: fix radio-mr800 hidquirks Alexey Klimov
2008-11-13 13:30 ` next: 6a13378a5 (Don't allow KWorld radio...) is broken Mauro Carvalho Chehab
2008-11-13 2:24 ` Alexey Klimov
2008-11-13 9:37 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491B3E90.5020307@gmail.com \
--to=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=klimov.linux@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=tobias.lorenz@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).