From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: next: 6a13378a5 (Don't allow KWorld radio...) is broken Date: Wed, 12 Nov 2008 21:37:36 +0100 Message-ID: <491B3E90.5020307@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from gv-out-0910.google.com ([216.239.58.186]:26620 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbYKLUhs (ORCPT ); Wed, 12 Nov 2008 15:37:48 -0500 Received: by gv-out-0910.google.com with SMTP id e6so172911gvc.37 for ; Wed, 12 Nov 2008 12:37:41 -0800 (PST) Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alexey Klimov Cc: Tobias Lorenz , Mauro Carvalho Chehab , Jiri Kosina , linux-input@vger.kernel.org, Linux Kernel Mailing List Hi guys, The commit below is apparently wrong. Maybe you CCed HID maintainer, however linux-input didn't get the message, or at least I can't find it anywhere. There is a difference between hid_blacklist and hid_ignore_list. One forbids generic hid driver to bind the device, while the other forces usbhid to release the device and move hands away from it. You picked up the former, which is wrong. I wonder if you were so lucky that you didn't hit it. Care to send a fixup with proper CCs? Thanks. commit 6a13378a56ce06afca9db75f3d4e663fba5f0992 Author: Alexey Klimov Date: Sun Oct 19 20:10:13 2008 -0300 V4L/DVB (9337a): HID: Don't allow KWorld radio fm700 be handled by usb hid d rivers This device is already handled by radio-si470x driver, and we therefore want usbhid to ignore it. Signed-off-by: Alexey Klimov Acked-by: Tobias Lorenz Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 1903e75..d3671b4 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1265,6 +1265,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERIC_13BA, USB_DEVICE_ID_GENERIC_13BA_ KBD_MOUSE) }, { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE) }, + { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700) }, { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2 ) }, { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEY BOARD) }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER) },