linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@bitmath.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: Add a detailed multi-touch finger data report protocol
Date: Fri, 21 Nov 2008 15:44:44 +0100	[thread overview]
Message-ID: <4926C95C.7000609@bitmath.org> (raw)
In-Reply-To: <20081119113508.ZZRA012@mailhub.coreip.homeip.net>

Dmitry,

My patch is all wrong. It would certainly benefit from using the
EV_SYN/SYN_MT_REPORT, but the defuzz mechanism of the EV_ABS class
simply will not work when sending data for several different fingers
using the same event.

I can see two clear alternatives: either add a new event class, EV_MT,
which sends all data without trying to limit the bandwidth, or forget
about the whole serial-finger-data idea and expand the current EV_ABS
class with an array of MT finger data [1]. I would very much appreciate
your input on this. Maybe there is a third option.

Cheers,
Henrik

[1] An example of a straight-forward addition of EV_ABS/ABS_MT events:

#define ABS_MT_FINGER_CNT	10
#define ABS_MT_PROPERTY_CNT	12

#define ABS_MT_FINGER_START	0x30
#define ABS_MT_TOUCH(x)		(ABS_MT_FINGER_START + 0 * ABS_MT_FINGER_CNT + x)
#define ABS_MT_WIDTH(x)		(ABS_MT_FINGER_START + 1 * ABS_MT_FINGER_CNT + x)
...
#define ABS_MT_FINGER_END	0xa8 /* = ABS_MT_FINGER_START + ABS_MT_PROPERTY_CNT * ABS_MT_FINGER_CNT */

  parent reply	other threads:[~2008-11-21 14:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 11:15 [PATCH] input: Add a detailed multi-touch finger data report protocol Henrik Rydberg
2008-11-07 13:34 ` J.R. Mauro
2008-11-07 14:26   ` Henrik Rydberg
2008-11-07 14:36     ` J.R. Mauro
2008-11-07 14:52       ` Henrik Rydberg
2008-11-07 14:57         ` J.R. Mauro
2008-11-07 15:07           ` Henrik Rydberg
2008-11-11  4:08         ` Peter Hutterer
2008-11-08  0:51 ` Arjan Opmeer
2008-11-08 10:43   ` Henrik Rydberg
2008-11-08 11:29     ` Arjan Opmeer
2008-11-08 12:02       ` Henrik Rydberg
2008-11-11  4:13       ` Peter Hutterer
2008-11-11  4:20 ` Peter Hutterer
2008-11-11 11:19   ` Henrik Rydberg
2008-11-19 16:37 ` Dmitry Torokhov
2008-11-19 16:54   ` Jim Gettys
2008-11-19 23:34     ` Henrik Rydberg
2008-11-21 14:43       ` Jim Gettys
2008-11-19 23:31   ` Henrik Rydberg
2008-11-21 14:44   ` Henrik Rydberg [this message]
2008-11-21 16:04     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4926C95C.7000609@bitmath.org \
    --to=rydberg@bitmath.org \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).