From: Jiri Slaby <jirislaby@gmail.com>
To: "Łukasz Lubojański" <lukasz@lubojanski.info>
Cc: Anssi Hannula <anssi.hannula@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org
Subject: Re: New Force Feedback device support - GreenAsia 0x12
Date: Sat, 06 Dec 2008 13:08:25 +0100 [thread overview]
Message-ID: <493A6B39.1070004@gmail.com> (raw)
In-Reply-To: <92cd8c320812051249m39bcd8d6mb03e15e14398f01c@mail.gmail.com>
On 12/05/2008 09:49 PM, Łukasz Lubojański wrote:
> Because the module supports only the FF now - I have changed module
> name to hid-gaff.
------=_Part_46985_7823613.1228510186768
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: base64
Content-Disposition: inline
:(
+#define debug(format, arg...) pr_debug("hid-gaff: " format "\n" , ## arg)
You don't need yet another pr_debug wrapper, use dev_dbg instead all over the code.
I would call the hid driver "hid-gaff" and won't add this to every print --
dev_* calls will do it on their own.
+static int ga_init(void)
mark as __init
+static void ga_exit(void)
mark as __exit
Otherwise looks good!
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-12-06 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 22:33 New Force Feedback device support - GreenAsia 0x12 Łukasz Lubojański
2008-11-26 23:01 ` Marek Vasut
2008-11-26 23:01 ` Jiri Slaby
2008-11-27 12:41 ` Jiri Kosina
2008-11-28 6:18 ` Łukasz Lubojański
2008-11-28 14:21 ` Jiri Kosina
2008-11-28 18:27 ` Anssi Hannula
2008-11-28 19:08 ` Łukasz Lubojański
2008-11-29 22:30 ` Jiri Kosina
2008-12-04 20:35 ` Łukasz Lubojański
2008-12-04 20:55 ` Łukasz Lubojański
2008-12-05 18:32 ` Anssi Hannula
2008-12-05 20:49 ` Łukasz Lubojański
2008-12-06 12:08 ` Jiri Slaby [this message]
2008-12-06 15:50 ` Anssi Hannula
[not found] ` <alpine.LNX.1.10.0812111610330.21089@jikos.suse.cz>
2008-12-11 19:46 ` Łukasz Lubojański
2008-12-11 21:13 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493A6B39.1070004@gmail.com \
--to=jirislaby@gmail.com \
--cc=anssi.hannula@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=lukasz@lubojanski.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).