* [PATCH 6/33] drivers/char: Make static [not found] <493EA286.7080500@gmail.com> @ 2008-12-09 17:12 ` Roel Kluin 2008-12-09 18:44 ` [PATCH 13/33] Input: " Roel Kluin 1 sibling, 0 replies; 3+ messages in thread From: Roel Kluin @ 2008-12-09 17:12 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-input, lkml Sparse asked whether these could be static. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- drivers/char/defkeymap.c_shipped | 6 +++--- drivers/char/keyboard.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/defkeymap.c_shipped b/drivers/char/defkeymap.c_shipped index d2208df..e930e3b 100644 --- a/drivers/char/defkeymap.c_shipped +++ b/drivers/char/defkeymap.c_shipped @@ -43,7 +43,7 @@ u_short shift_map[NR_KEYS] = { 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, }; -u_short altgr_map[NR_KEYS] = { +static u_short altgr_map[NR_KEYS] = { 0xf200, 0xf200, 0xf200, 0xf040, 0xf200, 0xf024, 0xf200, 0xf200, 0xf07b, 0xf05b, 0xf05d, 0xf07d, 0xf05c, 0xf200, 0xf200, 0xf200, 0xfb71, 0xfb77, 0xf918, 0xfb72, 0xfb74, 0xfb79, 0xfb75, 0xfb69, @@ -100,7 +100,7 @@ u_short shift_ctrl_map[NR_KEYS] = { 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, }; -u_short alt_map[NR_KEYS] = { +static u_short alt_map[NR_KEYS] = { 0xf200, 0xf81b, 0xf831, 0xf832, 0xf833, 0xf834, 0xf835, 0xf836, 0xf837, 0xf838, 0xf839, 0xf830, 0xf82d, 0xf83d, 0xf87f, 0xf809, 0xf871, 0xf877, 0xf865, 0xf872, 0xf874, 0xf879, 0xf875, 0xf869, @@ -119,7 +119,7 @@ u_short alt_map[NR_KEYS] = { 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, }; -u_short ctrl_alt_map[NR_KEYS] = { +static u_short ctrl_alt_map[NR_KEYS] = { 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf200, 0xf811, 0xf817, 0xf805, 0xf812, 0xf814, 0xf819, 0xf815, 0xf809, diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c index de26a97..564f719 100644 --- a/drivers/char/keyboard.c +++ b/drivers/char/keyboard.c @@ -151,7 +151,7 @@ static struct ledptr { /* Simple translation table for the SysRq keys */ #ifdef CONFIG_MAGIC_SYSRQ -unsigned char kbd_sysrq_xlate[KEY_MAX + 1] = +static unsigned char kbd_sysrq_xlate[KEY_MAX + 1] = "\000\0331234567890-=\177\t" /* 0x00 - 0x0f */ "qwertyuiop[]\r\000as" /* 0x10 - 0x1f */ "dfghjkl;'`\000\\zxcv" /* 0x20 - 0x2f */ ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 13/33] Input: Make static [not found] <493EA286.7080500@gmail.com> 2008-12-09 17:12 ` [PATCH 6/33] drivers/char: Make static Roel Kluin @ 2008-12-09 18:44 ` Roel Kluin 1 sibling, 0 replies; 3+ messages in thread From: Roel Kluin @ 2008-12-09 18:44 UTC (permalink / raw) To: Dmitry Torokhov, linux-input, lkml Sparse asked whether these could be static. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- drivers/input/mouse/gpio_mouse.c | 2 +- drivers/input/tablet/wacom_wac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c index 72cf5e3..0db8d16 100644 --- a/drivers/input/mouse/gpio_mouse.c +++ b/drivers/input/mouse/gpio_mouse.c @@ -173,7 +173,7 @@ static int __devexit gpio_mouse_remove(struct platform_device *pdev) /* work with hotplug and coldplug */ MODULE_ALIAS("platform:gpio_mouse"); -struct platform_driver gpio_mouse_device_driver = { +static struct platform_driver gpio_mouse_device_driver = { .remove = __devexit_p(gpio_mouse_remove), .driver = { .name = "gpio_mouse", diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 8dc8d1e..2638811 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c @@ -535,7 +535,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo) return 1; } -int wacom_tpc_irq(struct wacom_wac *wacom, void *wcombo) +static int wacom_tpc_irq(struct wacom_wac *wacom, void *wcombo) { char *data = wacom->data; int prox = 0, pressure; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 13/33] Input: Make static
@ 2008-12-20 10:50 Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2008-12-20 10:50 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-input, lkml
On Tuesday 09 December 2008 10:44:41 Roel Kluin wrote:
> Sparse asked whether these could be static.
>
Applied to 'next' branch, thank you Roel.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-20 10:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <493EA286.7080500@gmail.com> 2008-12-09 17:12 ` [PATCH 6/33] drivers/char: Make static Roel Kluin 2008-12-09 18:44 ` [PATCH 13/33] Input: " Roel Kluin 2008-12-20 10:50 Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).