From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Janne Grunau <j@jannau.net>
Subject: Re: [PATCH 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens
Date: Wed, 27 Nov 2024 11:25:47 +0100 [thread overview]
Message-ID: <495be827-f876-435b-977f-c563e8d51730@kernel.org> (raw)
In-Reply-To: <3FA9FD56-ECF4-4E2C-A300-7E552F60987D@gmail.com>
On 27/11/2024 11:22, Dmitry Torokhov wrote:
> On November 27, 2024 2:19:38 AM PST, Sasha Finkelstein <fnkl.kernel@gmail.com> wrote:
>> On Wed, 27 Nov 2024 at 10:00, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> + dev_err(dev, "unable to get reset");
>>>
>>> Syntax is: return dev_err_probe, almost everywhere here.
>>
>> Per discussion on previous version of this series, input asks
>> dev_err_probe to not be used.
>
> They twisted my arm. It's ok to use now.
I am fine if that's the preference for input, although this particular
case without dev_err_probe would be just wrong: possible dmesg flood on
deferral.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-27 10:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 20:47 [PATCH 0/4] Driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-26 20:47 ` [PATCH 1/4] dt-bindings: input: touchscreen: Add Z2 controller Sasha Finkelstein via B4 Relay
2024-11-27 8:46 ` Krzysztof Kozlowski
2024-11-27 10:33 ` Krzysztof Kozlowski
2024-11-27 10:49 ` Sasha Finkelstein
2024-11-27 11:23 ` Sasha Finkelstein
2024-11-27 12:03 ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-27 2:22 ` Dmitry Torokhov
2024-11-27 8:24 ` Sasha Finkelstein
2024-11-27 19:59 ` Dmitry Torokhov
2024-11-27 9:00 ` Krzysztof Kozlowski
2024-11-27 10:19 ` Sasha Finkelstein
2024-11-27 10:22 ` Dmitry Torokhov
2024-11-27 10:25 ` Krzysztof Kozlowski [this message]
2024-11-26 20:48 ` [PATCH 3/4] arm64: dts: apple: Add touchbar digitizer nodes Sasha Finkelstein via B4 Relay
2024-11-26 21:14 ` Janne Grunau
2024-11-27 8:55 ` Krzysztof Kozlowski
2024-11-27 10:31 ` Sasha Finkelstein
2024-11-27 10:34 ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 4/4] MAINTAINERS: Add entries for Apple Z2 touchscreen driver Sasha Finkelstein via B4 Relay
2024-11-27 1:51 ` [PATCH 0/4] Driver for Apple Z2 touchscreens Dmitry Torokhov
2024-11-27 8:29 ` Sasha Finkelstein
2024-11-27 15:29 ` Hector Martin
2024-11-27 16:20 ` Hector Martin
2024-11-28 8:37 ` Janne Grunau
2024-11-27 10:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495be827-f876-435b-977f-c563e8d51730@kernel.org \
--to=krzk@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).