[RFC] mfd/ucb1400: don't depend on gpiolib

[RFC] mfd/ucb1400: don't depend on gpiolib

[Sebastian Andrzej Siewior]

it didn't in the past and I can't see how it does.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.

 drivers/mfd/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 2572773..8bcd600 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -53,7 +53,6 @@ config HTC_PASIC3
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
 	depends on AC97_BUS
-	depends on GPIOLIB
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.
-- 
1.5.6.5

Re: [RFC] mfd/ucb1400: don't depend on gpiolib

[Marek Vasut]

On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:
> it didn't in the past and I can't see how it does.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.
>
>  drivers/mfd/Kconfig |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 2572773..8bcd600 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -53,7 +53,6 @@ config HTC_PASIC3
>  config UCB1400_CORE
>  	tristate "Philips UCB1400 Core driver"
>  	depends on AC97_BUS
> -	depends on GPIOLIB
>  	help
>  	  This enables support for the Philips UCB1400 core functions.
>  	  The UCB1400 is an AC97 audio codec.

That dependency was added there later, I got email from Andrew Morton from 
22.9.2008 23:44 adding that there, go ask him about it. CCed.

Re: [RFC] mfd/ucb1400: don't depend on gpiolib

[Sebastian Andrzej Siewior]

Marek Vasut wrote:
> On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:
>> it didn't in the past and I can't see how it does.
>>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> ---
>> I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.
>>
>>  drivers/mfd/Kconfig |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 2572773..8bcd600 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -53,7 +53,6 @@ config HTC_PASIC3
>>  config UCB1400_CORE
>>  	tristate "Philips UCB1400 Core driver"
>>  	depends on AC97_BUS
>> -	depends on GPIOLIB
>>  	help
>>  	  This enables support for the Philips UCB1400 core functions.
>>  	  The UCB1400 is an AC97 audio codec.
> 
> That dependency was added there later, I got email from Andrew Morton from 
> 22.9.2008 23:44 adding that there, go ask him about it. CCed.

The header file exports functions which have gpio in its name. However I 
did not find any users in tree.
Andrew, do you remember the reason why GPIOLIB got added as a dependency?

Sebastian

Re: [RFC] mfd/ucb1400: don't depend on gpiolib

[Sebastian Andrzej Siewior]

Sebastian Andrzej Siewior wrote:
> Marek Vasut wrote:
>> On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:
>>> it didn't in the past and I can't see how it does.
>>>
>>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>> ---
>>> I use ucb1400 with its ts capabilities without *gpiolib* on a ppc 
>>> system.
>>>
>>>  drivers/mfd/Kconfig |    1 -
>>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>>> index 2572773..8bcd600 100644
>>> --- a/drivers/mfd/Kconfig
>>> +++ b/drivers/mfd/Kconfig
>>> @@ -53,7 +53,6 @@ config HTC_PASIC3
>>>  config UCB1400_CORE
>>>      tristate "Philips UCB1400 Core driver"
>>>      depends on AC97_BUS
>>> -    depends on GPIOLIB
>>>      help
>>>        This enables support for the Philips UCB1400 core functions.
>>>        The UCB1400 is an AC97 audio codec.
>>
>> That dependency was added there later, I got email from Andrew Morton 
>> from 22.9.2008 23:44 adding that there, go ask him about it. CCed.
> 
> The header file exports functions which have gpio in its name. However I 
> did not find any users in tree.
> Andrew, do you remember the reason why GPIOLIB got added as a dependency?

I've found [1]. Will look later into it.

[1] http://marc.info/?l=linux-mm-commits&m=121919139002830&w=2

Sebastian