linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: simon@mungewell.org
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "\"Michal Malý\"" <madcatxster@devoid-pointer.net>,
	linux-kernel@vger.kernel.org,
	"HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
Date: Wed, 23 Apr 2014 11:06:54 -0400	[thread overview]
Message-ID: <4977a0bbe5c8625d93f771983991f30a.squirrel@mungewell.org> (raw)
In-Reply-To: <87r44ofw1x.fsf@rustcorp.com.au>

> simon@mungewell.org writes:
>>> In line with practice for module parameters, we're adding a build-time
>>> check that sysfs files aren't world-writable.
>>
>> So this is the equivalent of 'chmod 774 ...' rather than 'chmod
>> 777...'?
>
> Yep.  Though not sure why it was 777 rather than 666...
>
>> Yep I'm OK with that, however what it the recommended way to make sure
>> that the end user is able to send changes to this /sys portal? I asked
>> the
>> same question before regarding the led class /sys interface, but never
>> got
>> any suggestions.
>>
>> Signed-off-by: Simon Wood <simon@mungewell.org>
>
> If you need that, we'll need to make an exception.  That's one purpose
> of spamming everyone with these changs...


What's the right way of doing it?... I don't need to be 'special'. ;-)

The '/sys/.../range' control allows the user to limit the rotation of the
gaming wheel from a maximum of 900' down to match the 'car' they
sim-driving. Probably not many people use it, but it probably should be
assigned properly.

With gaming controllers the /dev/input/event* seem to get set
appropriately, but I'm not sure how this happens.

The same /should/ also happen for all the LED class controls, I don't want
to have to 'sudo' just to set a LED on/off. This is currently a problem
for (at least) hid-lg, hid-sony and hid-steelseries.
Simon

       reply	other threads:[~2014-04-23 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1398137612-9714-1-git-send-email-rusty@rustcorp.com.au>
     [not found] ` <1398137612-9714-4-git-send-email-rusty@rustcorp.com.au>
     [not found]   ` <9d9a3af40f8a0da293e52610524674c8.squirrel@mungewell.org>
     [not found]     ` <87r44ofw1x.fsf@rustcorp.com.au>
2014-04-23 15:06       ` simon [this message]
2014-04-24  3:25         ` [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4977a0bbe5c8625d93f771983991f30a.squirrel@mungewell.org \
    --to=simon@mungewell.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madcatxster@devoid-pointer.net \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).