* [PATCH] Input, blackfin: ! has a higher priority than >
@ 2009-01-28 22:22 Roel Kluin
2009-01-29 9:08 ` Hennerich, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-01-28 22:22 UTC (permalink / raw)
To: Dmitry Torokhov, michael.hennerich, cooloney; +Cc: linux-input
! has a higher priority than >
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index 1928401..ee855c5 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -209,8 +209,8 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
goto out;
}
- if (!pdata->debounce_time || !pdata->debounce_time > MAX_MULT ||
- !pdata->coldrive_time || !pdata->coldrive_time > MAX_MULT) {
+ if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
+ !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
printk(KERN_ERR DRV_NAME
": Invalid Debounce/Columdrive Time from pdata\n");
bfin_write_KPAD_MSEL(0xFF0); /* Default MSEL */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Input, blackfin: ! has a higher priority than >
2009-01-28 22:22 [PATCH] Input, blackfin: ! has a higher priority than > Roel Kluin
@ 2009-01-29 9:08 ` Hennerich, Michael
2009-01-30 7:10 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Hennerich, Michael @ 2009-01-29 9:08 UTC (permalink / raw)
To: Roel Kluin, Dmitry Torokhov, michael.hennerich, cooloney; +Cc: linux-input
>From: Roel Kluin [mailto:roel.kluin@gmail.com]
>
>! has a higher priority than >
>
>Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>---
>diff --git a/drivers/input/keyboard/bf54x-keys.c
>b/drivers/input/keyboard/bf54x-keys.c
>index 1928401..ee855c5 100644
>--- a/drivers/input/keyboard/bf54x-keys.c
>+++ b/drivers/input/keyboard/bf54x-keys.c
>@@ -209,8 +209,8 @@ static int __devinit bfin_kpad_probe(struct
>platform_device *pdev)
> goto out;
> }
>
>- if (!pdata->debounce_time || !pdata->debounce_time > MAX_MULT ||
>- !pdata->coldrive_time || !pdata->coldrive_time > MAX_MULT) {
>+ if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
>+ !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
> printk(KERN_ERR DRV_NAME
> ": Invalid Debounce/Columdrive Time from
pdata\n");
> bfin_write_KPAD_MSEL(0xFF0); /* Default MSEL */
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Thanks,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input, blackfin: ! has a higher priority than >
2009-01-29 9:08 ` Hennerich, Michael
@ 2009-01-30 7:10 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2009-01-30 7:10 UTC (permalink / raw)
To: Hennerich, Michael; +Cc: Roel Kluin, cooloney, linux-input
On Thu, Jan 29, 2009 at 09:08:45AM -0000, Hennerich, Michael wrote:
>
>
> >From: Roel Kluin [mailto:roel.kluin@gmail.com]
> >
> >! has a higher priority than >
> >
> >Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> >---
> >diff --git a/drivers/input/keyboard/bf54x-keys.c
> >b/drivers/input/keyboard/bf54x-keys.c
> >index 1928401..ee855c5 100644
> >--- a/drivers/input/keyboard/bf54x-keys.c
> >+++ b/drivers/input/keyboard/bf54x-keys.c
> >@@ -209,8 +209,8 @@ static int __devinit bfin_kpad_probe(struct
> >platform_device *pdev)
> > goto out;
> > }
> >
> >- if (!pdata->debounce_time || !pdata->debounce_time > MAX_MULT ||
> >- !pdata->coldrive_time || !pdata->coldrive_time > MAX_MULT) {
> >+ if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
> >+ !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
> > printk(KERN_ERR DRV_NAME
> > ": Invalid Debounce/Columdrive Time from
> pdata\n");
> > bfin_write_KPAD_MSEL(0xFF0); /* Default MSEL */
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>
Applied to 'for-linus', thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-30 7:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 22:22 [PATCH] Input, blackfin: ! has a higher priority than > Roel Kluin
2009-01-29 9:08 ` Hennerich, Michael
2009-01-30 7:10 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).