linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Filipe Laíns" <filipe.lains@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: (hid-logitech) Support for non-DJ receivers
Date: Wed, 06 Jan 2021 19:07:22 +0000	[thread overview]
Message-ID: <4990836470c5fb01babcf416ca6ccf9e5e21d152.camel@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

Hey,

Some of the new Logitech receivers do not have the DJ interface, this creates an
issue userspace applications like libratbag, as seen in [1], because we can't
identify the device based on the hidraw PID.

There are two solutions for this:

1) Implement device discovery via the internal Logitech ID in libratbag and all
other userspace apps.

2) Make hid-logitech-dj export a duplicated hidraw node with internal Logitech
ID as PID, just like it does for the DJ interface.

In case you aren't aware of what the DJ interface is, it is essentially a
multiplexing protocol that receivers support. 6 devices could be connected to
the same receiver, hid-logitech-dj enables the DJ mode and the receiver will
essentially perpend the device ID to each HID report. hid-logitech-dj then
creates a HID device for each connected device and routes the HID reports to the
correspondent HID device.

Option 2) would be the easier on userspace, as it keeps the same interface we
use for DJ receivers for other Logitech HID++ receivers and avoids all userspace
apps to have to reimplement the same discovery logic.

Any thoughts?

[1] https://github.com/libratbag/libratbag/pull/1071

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2021-01-06 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 19:07 Filipe Laíns [this message]
2021-01-06 19:16 ` (hid-logitech) Support for non-DJ receivers Hans de Goede
2021-01-06 19:20   ` Filipe Laíns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4990836470c5fb01babcf416ca6ccf9e5e21d152.camel@gmail.com \
    --to=filipe.lains@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).