From: Jiri Slaby <jirislaby@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite
Date: Mon, 02 Mar 2009 15:15:13 +0100 [thread overview]
Message-ID: <49ABE9F1.9060201@gmail.com> (raw)
In-Reply-To: <20090302140044.GA23038@rakim.wolfsonmicro.main>
On 2.3.2009 15:00, Mark Brown wrote:
> On Mon, Mar 02, 2009 at 02:44:28PM +0100, Jiri Slaby wrote:
>> On 2.3.2009 14:23, Mark Brown wrote:
>>> + int count = 16;
>>> + schedule_timeout_uninterruptible(1);
[...]
>>> + while (count< 16) {
>
>> Weird condition.
>> + conding style
>
> Hrm. This appears to have been mangled somewhere in the mail path to
> you - the indentation is normal in my send-mail folder and in the copy I
> got back from the list.
OK, anyway the condition looks weird on a semantic layer.
>>> +static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
>>> +{
>>> + if (enable)
>>> + enable_irq(wm->pen_irq);
>>> + else
>>> + disable_irq(wm->pen_irq);
>
>> sync?
>
> Could you expand on this, please?
No, I was wrong, ignore this one. It's called from within the interrupt
it disables.
prev parent reply other threads:[~2009-03-02 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 13:23 [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Mark Brown
2009-03-02 13:23 ` [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors Mark Brown
2009-03-02 14:34 ` Jiri Slaby
2009-03-02 22:33 ` Jiri Slaby
2009-03-02 23:02 ` Mark Brown
2009-03-03 9:13 ` Dmitry Torokhov
2009-03-03 10:35 ` Mark Brown
2009-03-02 13:44 ` [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Jiri Slaby
2009-03-02 14:00 ` Mark Brown
2009-03-02 14:15 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ABE9F1.9060201@gmail.com \
--to=jirislaby@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).