From: Mike Rapoport <mike@compulab.co.il>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: dmitry.torokhov@gmail.com, LKML <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH RESEND] Input: wm97xx: add BTN_TOUCH event to wm97xx to use it with Android
Date: Mon, 02 Mar 2009 18:16:55 +0200 [thread overview]
Message-ID: <49AC0677.7040102@compulab.co.il> (raw)
In-Reply-To: <20090302142838.GA23342@rakim.wolfsonmicro.main>
Mark,
Mark Brown wrote:
> On Mon, Mar 02, 2009 at 04:12:08PM +0200, Mike Rapoport wrote:
>> Android expects BTN_TOUCH events when pen state changes. Add BTN_TOUCH
>> event reporting to allow use of wm97xx touchscreen controller with
>> Android devices.
>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> I'd still like to see more consistency over touchscreen drivers on this
> one, BTW - if we're doing this it should be done for all touchscreen
> drivers (either by updating the individual drivers or having the input
> core do it). This isn't the only touchscreen driver that doesn't do
> BTN_TOUCH.
Most touchscreen drivers already have BTN_TOUCH event generation:
> git-grep -L BTN_TOUCH v2.6.29-rc6 drivers/input/touchscreen/
v2.6.29-rc6:drivers/input/touchscreen/Kconfig
v2.6.29-rc6:drivers/input/touchscreen/Makefile
v2.6.29-rc6:drivers/input/touchscreen/mainstone-wm97xx.c
v2.6.29-rc6:drivers/input/touchscreen/ucb1400_ts.c
v2.6.29-rc6:drivers/input/touchscreen/wm9705.c
v2.6.29-rc6:drivers/input/touchscreen/wm9712.c
v2.6.29-rc6:drivers/input/touchscreen/wm9713.c
v2.6.29-rc6:drivers/input/touchscreen/wm97xx-core.c
If there no objection I can make a similar patch for mainstone-wm97xx.c and ucb1400_ts.c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2009-03-02 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 14:12 [PATCH RESEND] Input: wm97xx: add BTN_TOUCH event to wm97xx to use it with Android Mike Rapoport
2009-03-02 14:28 ` Mark Brown
2009-03-02 16:16 ` Mike Rapoport [this message]
2009-03-02 16:21 ` Mark Brown
2009-03-03 8:27 ` [PATCH] Input: add BTN_TOUCH event (Was: [PATCH RESEND] Input: wm97xx: add BTN_TOUCH event to wm97xx) Mike Rapoport
2009-03-03 8:30 ` [PATCH RESEND] Input: wm97xx: add BTN_TOUCH event to wm97xx to use it with Android Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AC0677.7040102@compulab.co.il \
--to=mike@compulab.co.il \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).