From: Zoltan Karcagi <zkr@freemail.hu>
To: linux-input@vger.kernel.org
Subject: [PATCH] HID: Fix dropped device-specific quirks
Date: Mon, 04 May 2009 18:57:55 +0200 [thread overview]
Message-ID: <49FF1E93.7010704@freemail.hu> (raw)
Hi,
(Originally sent to linux-usb, description slightly rephrased.)
Please consider for merging. Without this patch, the device below does not work at all on kernel 2.6.28
and upwards.
Device-specific quirks are set up correctly in their respective vendor-specific driver, then
get overwritten in usbhid_parse().
Found on a Microsoft Wireless Optical Desktop 3.0 [045e:009d].
Signed-off-by: Zoltan Karcagi <zkr@freemail.hu>
diff -r -U 5 linux-2.6.30-rc4/drivers/hid/usbhid/hid-core.c linux-2.6.30-rc4-fixed/drivers/hid/usbhid/hid-core.c
--- linux-2.6.30-rc4/drivers/hid/usbhid/hid-core.c 2009-05-01 12:06:18.000000000 +0200
+++ linux-2.6.30-rc4-fixed/drivers/hid/usbhid/hid-core.c 2009-05-03 14:43:47.000000000 +0200
@@ -896,11 +896,11 @@
if (ret) {
dbg_hid("parsing report descriptor failed\n");
goto err;
}
- hid->quirks = quirks;
+ hid->quirks |= quirks;
return 0;
err:
return ret;
}
next reply other threads:[~2009-05-04 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 16:57 Zoltan Karcagi [this message]
2009-05-06 14:35 ` [PATCH] HID: Fix dropped device-specific quirks Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FF1E93.7010704@freemail.hu \
--to=zkr@freemail.hu \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).