linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Bader <stefan.bader@canonical.com>
To: linux-input@vger.kernel.org
Cc: dtor@mail.ru
Subject: [PATCH] input: Blacklist digitizers from joydev.c
Date: Mon, 04 May 2009 19:25:56 +0200	[thread overview]
Message-ID: <49FF2524.8090708@canonical.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

This patch has been included in Ubuntu. Does it look sensible for upstream 
inclusion?

Stefan



[-- Attachment #2: 0001-UBUNTU-SAUCE-input-Blacklist-digitizers-from-joyd.patch --]
[-- Type: text/x-diff, Size: 1566 bytes --]

>From 79d826fd1e314846b889fd524eab0a9445f0f70a Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Tue, 28 Apr 2009 16:44:18 +0200
Subject: [PATCH] UBUNTU: SAUCE: input: Blacklist digitizers from joydev.c

Bug: #300143
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/300143

BTN_TOUCH is not set by the wacom driver which causes it to be handled by the
joydev driver while the resulting device is broken. This causes problems
with applications that try to use a joystick device.

Signed-off-by: Tim Cole <tim.cole@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Amit Kucheria <amit.kucheria@canonical.com>
---
 drivers/input/joydev.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
index a85b148..cef2333 100644
--- a/drivers/input/joydev.c
+++ b/drivers/input/joydev.c
@@ -846,7 +846,13 @@ static const struct input_device_id joydev_blacklist[] = {
 				INPUT_DEVICE_ID_MATCH_KEYBIT,
 		.evbit = { BIT_MASK(EV_KEY) },
 		.keybit = { [BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH) },
-	},	/* Avoid itouchpads, touchscreens and tablets */
+	},	/* Avoid itouchpads and touchscreens */
+	{
+		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
+				INPUT_DEVICE_ID_MATCH_KEYBIT,
+		.evbit = { BIT_MASK(EV_KEY) },
+		.keybit = { [BIT_WORD(BTN_DIGI)] = BIT_MASK(BTN_DIGI) },
+	},	/* Avoid tablets, digitisers and similar devices */
 	{ }	/* Terminating entry */
 };
 
-- 
1.5.4.3


             reply	other threads:[~2009-05-04 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 17:25 Stefan Bader [this message]
2009-05-05 17:02 ` [PATCH] input: Blacklist digitizers from joydev.c Dmitry Torokhov
2009-05-05 17:18   ` Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FF2524.8090708@canonical.com \
    --to=stefan.bader@canonical.com \
    --cc=dtor@mail.ru \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).