From: Jiri Slaby <jslaby@suse.cz>
To: Greg KH <greg@kroah.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] hid: add force feedback support for SmartJoy PLUS PS2/USB adapter
Date: Tue, 12 May 2009 00:02:27 +0200 [thread overview]
Message-ID: <4A08A073.60005@suse.cz> (raw)
In-Reply-To: <20090511214620.GA22717@kroah.com>
On 05/11/2009 11:46 PM, Greg KH wrote:
> On Mon, May 11, 2009 at 05:48:55PM +0200, Jiri Slaby wrote:
>> Here comes some of my comments to the rest:
>>
>> +#define debug(format, arg...) pr_debug("hid-sjoyff: " format "\n" , ## arg)
>>
>> Define pr_fmt instead of this.
>
> No, please use dev_dbg() instead of creating a new macro.
No, unfortunately there is no struct device available in the two
functions he uses this macro in.
It should look like
#define pr_fmt(fmt) "hid-sjoyff: " fmt "\n"
and then use pr_debug as usual.
In other places he correctly uses dev_* stuff.
Thanks.
next prev parent reply other threads:[~2009-05-11 22:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 7:46 [PATCH] hid: add force feedback support for SmartJoy PLUS PS2/USB adapter Jussi Kivilinna
2009-05-08 8:02 ` Oliver Neukum
[not found] ` <200905081002.56647.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-05-08 8:37 ` Jussi Kivilinna
2009-05-11 15:17 ` Jiri Kosina
2009-05-11 15:48 ` Jiri Slaby
[not found] ` <4A0848E7.9080301-AlSwsSmVLrQ@public.gmane.org>
2009-05-11 15:51 ` Jiri Kosina
2009-05-11 15:53 ` Jiri Slaby
2009-05-25 10:16 ` Jiri Slaby
2009-06-02 9:16 ` Jiri Kosina
2009-05-11 16:05 ` Jussi Kivilinna
2009-05-11 21:46 ` Greg KH
2009-05-11 22:02 ` Jiri Slaby [this message]
2009-05-11 22:02 ` Greg KH
2009-05-13 8:10 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A08A073.60005@suse.cz \
--to=jslaby@suse.cz \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).