From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] hid: add force feedback support for SmartJoy PLUS	PS2/USB
 adapter
Date: Tue, 12 May 2009 00:02:27 +0200
Message-ID: <4A08A073.60005@suse.cz>
References: <20090508074636.16912.55839.stgit@fate.lan> <alpine.LNX.2.00.0905111712410.22712@wotan.suse.de> <4A0848E7.9080301@suse.cz> <20090511214620.GA22717@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-input-owner@vger.kernel.org>
Received: from mail-fx0-f158.google.com ([209.85.220.158]:58592 "EHLO
	mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756361AbZEKWCp (ORCPT
	<rfc822;linux-input@vger.kernel.org>);
	Mon, 11 May 2009 18:02:45 -0400
In-Reply-To: <20090511214620.GA22717@kroah.com>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Greg KH <greg@kroah.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Jussi Kivilinna <jussi.kivilinna@mbnet.fi>, linux-usb@vger.kernel.org, linux-input@vger.kernel.org

On 05/11/2009 11:46 PM, Greg KH wrote:
> On Mon, May 11, 2009 at 05:48:55PM +0200, Jiri Slaby wrote:
>> Here comes some of my comments to the rest:
>>
>> +#define debug(format, arg...) pr_debug("hid-sjoyff: " format "\n" , ## arg)
>>
>> Define pr_fmt instead of this.
> 
> No, please use dev_dbg() instead of creating a new macro.

No, unfortunately there is no struct device available in the two
functions he uses this macro in.

It should look like

#define pr_fmt(fmt) "hid-sjoyff: " fmt "\n"

and then use pr_debug as usual.

In other places he correctly uses dev_* stuff.

Thanks.