From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anssi Hannula Subject: Re: hid-pidff bug: fails to find all required reports of saitek gamepad Date: Sat, 06 Jun 2009 15:14:06 +0300 Message-ID: <4A2A5D8E.1050309@gmail.com> References: <78f5d6bf0901301145g591a713agc8aafa66fe27b19f@mail.gmail.com> <49AC4300.5090002@gmail.com> <78f5d6bf0903022228l30c53db1k5d51ed7aeeb76e51@mail.gmail.com> <78f5d6bf0903031035r44a9c655n2cb0408ddf10d7d1@mail.gmail.com> <49B286EB.8000300@gmail.com> <78f5d6bf0903072118i19bc91a0taa4a5bda0fb19bf6@mail.gmail.com> <49B39B15.6060609@gmail.com> <78f5d6bf0903091208i71aadc0od7b89ab9a4037b4d@mail.gmail.com> <4A037290.60602@gmail.com> <4A03756C.6020703@gmail.com> <78f5d6bf0906041227w3a58bde0u554a3d3336e17fa6@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060906030106010206020205" Return-path: Received: from mta-out.inet.fi ([195.156.147.13]:56684 "EHLO jenni2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239AbZFFMOI (ORCPT ); Sat, 6 Jun 2009 08:14:08 -0400 In-Reply-To: <78f5d6bf0906041227w3a58bde0u554a3d3336e17fa6@mail.gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitriy Geels Cc: linux-input@vger.kernel.org This is a multi-part message in MIME format. --------------060906030106010206020205 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Dmitriy Geels wrote: > 2009/5/8 Anssi Hannula : >> Anssi Hannula wrote: >>> Dmitriy Geels wrote: >>>> 2009/3/8 Anssi Hannula : >>>>> Dmitriy Geels wrote: >>>>>> 2009/3/7 Anssi Hannula : >>>>>>> Provide the kernel log again, this time with debug=2 set for hid module >>>>>>> and having run "fftest" with only one effect and then "ffmvforce". >>>>>> here is it: http://paste.org.ru/index.pl?4bwah8 >>>>> Apply attached patch that adds more debug output and try this again. >>>> Here is log: http://paste.org.ru/index.pl?0mtjuz >>>> >>> Sorry for the long delay. >>> >>> Try the attached (untested) patch. It adds a simple timeout to the hid >>> ctrl and out urbs, discarding the faulty urb instead of getting stuck. >> And of course there was an error, attached is a fixed patch :) > Just tried to build module with your patch. It doesn't build. > Fixed patch attached. -- Anssi Hannula --------------060906030106010206020205 Content-Type: text/plain; name="hid-usb-add-urb-timeout.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="hid-usb-add-urb-timeout.diff" LS0tCiBkcml2ZXJzL2hpZC91c2JoaWQvaGlkLWNvcmUuYyB8ICAgMjEgKysrKysrKysrKysr KysrKysrKysrCiBkcml2ZXJzL2hpZC91c2JoaWQvdXNiaGlkLmggICB8ICAgIDIgKysKIDIg ZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKQoKSW5kZXg6IGxpbnV4LTI2MjktcGlk ZmYvZHJpdmVycy9oaWQvdXNiaGlkL2hpZC1jb3JlLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGlu dXgtMjYyOS1waWRmZi5vcmlnL2RyaXZlcnMvaGlkL3VzYmhpZC9oaWQtY29yZS5jCTIwMDkt MDItMTMgMDM6NDc6MTUuMDAwMDAwMDAwICswMjAwCisrKyBsaW51eC0yNjI5LXBpZGZmL2Ry aXZlcnMvaGlkL3VzYmhpZC9oaWQtY29yZS5jCTIwMDktMDYtMDYgMTU6MDg6MDkuMDAwMDAw MDAwICswMzAwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSA8YXNtL2J5dGVvcmRlci5o PgogI2luY2x1ZGUgPGxpbnV4L2lucHV0Lmg+CiAjaW5jbHVkZSA8bGludXgvd2FpdC5oPgor I2luY2x1ZGUgPGxpbnV4L3RpbWVyLmg+CiAKICNpbmNsdWRlIDxsaW51eC91c2IuaD4KIApA QCAtMjUxLDYgKzI1Miw5IEBAIHN0YXRpYyBpbnQgaGlkX3N1Ym1pdF9vdXQoc3RydWN0IGhp ZF9kZXYKIAkJcmV0dXJuIC0xOwogCX0KIAorCXVzYmhpZC0+dXJiX291dF90aW1lb3V0LmV4 cGlyZXMgPSBqaWZmaWVzICsgbXNlY3NfdG9famlmZmllcyg4MDAwKTsKKwlhZGRfdGltZXIo JnVzYmhpZC0+dXJiX291dF90aW1lb3V0KTsKKwogCXJldHVybiAwOwogfQogCkBAIC0zMDMs NiArMzA3LDkgQEAgc3RhdGljIGludCBoaWRfc3VibWl0X2N0cmwoc3RydWN0IGhpZF9kZQog CQlyZXR1cm4gLTE7CiAJfQogCisJdXNiaGlkLT51cmJfY3RybF90aW1lb3V0LmV4cGlyZXMg PSBqaWZmaWVzICsgbXNlY3NfdG9famlmZmllcyg4MDAwKTsKKwlhZGRfdGltZXIoJnVzYmhp ZC0+dXJiX2N0cmxfdGltZW91dCk7CisKIAlyZXR1cm4gMDsKIH0KIApAQCAtMzE3LDYgKzMy NCw4IEBAIHN0YXRpYyB2b2lkIGhpZF9pcnFfb3V0KHN0cnVjdCB1cmIgKnVyYikKIAl1bnNp Z25lZCBsb25nIGZsYWdzOwogCWludCB1bnBsdWcgPSAwOwogCisJZGVsX3RpbWVyKCZ1c2Jo aWQtPnVyYl9vdXRfdGltZW91dCk7CisKIAlzd2l0Y2ggKHVyYi0+c3RhdHVzKSB7CiAJY2Fz ZSAwOgkJCS8qIHN1Y2Nlc3MgKi8KIAkJYnJlYWs7CkBAIC0zNjQsNiArMzczLDcgQEAgc3Rh dGljIHZvaWQgaGlkX2N0cmwoc3RydWN0IHVyYiAqdXJiKQogCXVuc2lnbmVkIGxvbmcgZmxh Z3M7CiAJaW50IHVucGx1ZyA9IDA7CiAKKwlkZWxfdGltZXIoJnVzYmhpZC0+dXJiX2N0cmxf dGltZW91dCk7CiAJc3Bpbl9sb2NrX2lycXNhdmUoJnVzYmhpZC0+Y3RybGxvY2ssIGZsYWdz KTsKIAogCXN3aXRjaCAodXJiLT5zdGF0dXMpIHsKQEAgLTQwNSw2ICs0MTUsMTMgQEAgc3Rh dGljIHZvaWQgaGlkX2N0cmwoc3RydWN0IHVyYiAqdXJiKQogCXdha2VfdXAoJnVzYmhpZC0+ d2FpdCk7CiB9CiAKK3N0YXRpYyB2b2lkIGhpZF91cmJfdGltZW91dCh1bnNpZ25lZCBsb25n IHRpbWVyX2RhdGEpCit7CisJc3RydWN0IHVyYiAqaGlkX3VyYiA9IChzdHJ1Y3QgdXJiICop dGltZXJfZGF0YTsKKwlkZXZfd2FybigmaGlkX3VyYi0+ZGV2LT5kZXYsICJoaWQgdXJiIHRp bWVvdXRcbiIpOworCXVzYl91bmxpbmtfdXJiKGhpZF91cmIpOworfQorCiB2b2lkIHVzYmhp ZF9zdWJtaXRfcmVwb3J0KHN0cnVjdCBoaWRfZGV2aWNlICpoaWQsIHN0cnVjdCBoaWRfcmVw b3J0ICpyZXBvcnQsIHVuc2lnbmVkIGNoYXIgZGlyKQogewogCWludCBoZWFkOwpAQCAtODUx LDYgKzg2OCw4IEBAIHN0YXRpYyBpbnQgdXNiaGlkX3N0YXJ0KHN0cnVjdCBoaWRfZGV2aWMK IAlpbml0X3dhaXRxdWV1ZV9oZWFkKCZ1c2JoaWQtPndhaXQpOwogCUlOSVRfV09SSygmdXNi aGlkLT5yZXNldF93b3JrLCBoaWRfcmVzZXQpOwogCXNldHVwX3RpbWVyKCZ1c2JoaWQtPmlv X3JldHJ5LCBoaWRfcmV0cnlfdGltZW91dCwgKHVuc2lnbmVkIGxvbmcpIGhpZCk7CisJc2V0 dXBfdGltZXIoJnVzYmhpZC0+dXJiX291dF90aW1lb3V0LCBoaWRfdXJiX3RpbWVvdXQsICh1 bnNpZ25lZCBsb25nKSB1c2JoaWQtPnVyYm91dCk7CisJc2V0dXBfdGltZXIoJnVzYmhpZC0+ dXJiX2N0cmxfdGltZW91dCwgaGlkX3VyYl90aW1lb3V0LCAodW5zaWduZWQgbG9uZykgdXNi aGlkLT51cmJjdHJsKTsKIAogCXNwaW5fbG9ja19pbml0KCZ1c2JoaWQtPmlubG9jayk7CiAJ c3Bpbl9sb2NrX2luaXQoJnVzYmhpZC0+b3V0bG9jayk7CkBAIC05MTUsNiArOTM0LDggQEAg c3RhdGljIHZvaWQgdXNiaGlkX3N0b3Aoc3RydWN0IGhpZF9kZXZpYwogCiAJZGVsX3RpbWVy X3N5bmMoJnVzYmhpZC0+aW9fcmV0cnkpOwogCWNhbmNlbF93b3JrX3N5bmMoJnVzYmhpZC0+ cmVzZXRfd29yayk7CisJZGVsX3RpbWVyX3N5bmMoJnVzYmhpZC0+dXJiX291dF90aW1lb3V0 KTsKKwlkZWxfdGltZXJfc3luYygmdXNiaGlkLT51cmJfY3RybF90aW1lb3V0KTsKIAogCWlm IChoaWQtPmNsYWltZWQgJiBISURfQ0xBSU1FRF9JTlBVVCkKIAkJaGlkaW5wdXRfZGlzY29u bmVjdChoaWQpOwpJbmRleDogbGludXgtMjYyOS1waWRmZi9kcml2ZXJzL2hpZC91c2JoaWQv dXNiaGlkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtMjYyOS1waWRmZi5vcmlnL2RyaXZl cnMvaGlkL3VzYmhpZC91c2JoaWQuaAkyMDA5LTA1LTA4IDAxOjUzOjMzLjAwMDAwMDAwMCAr MDMwMAorKysgbGludXgtMjYyOS1waWRmZi9kcml2ZXJzL2hpZC91c2JoaWQvdXNiaGlkLmgJ MjAwOS0wNS0wOCAwMTo1NDowMi4wMDAwMDAwMDAgKzAzMDAKQEAgLTg1LDYgKzg1LDggQEAg c3RydWN0IHVzYmhpZF9kZXZpY2UgewogCXNwaW5sb2NrX3Qgb3V0bG9jazsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBPdXRwdXQgZmlmbyBzcGlu bG9jayAqLwogCiAJdW5zaWduZWQgbG9uZyBpb2ZsOyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIC8qIEkvTyBmbGFncyAoQ1RSTF9SVU5OSU5HLCBPVVRf UlVOTklORykgKi8KKwlzdHJ1Y3QgdGltZXJfbGlzdCB1cmJfb3V0X3RpbWVvdXQ7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLyogVGltZW91dCBmb3Igb3V0IHVyYiAqLworCXN0 cnVjdCB0aW1lcl9saXN0IHVyYl9jdHJsX3RpbWVvdXQ7ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAvKiBUaW1lb3V0IGZvciBjdHJsIHVyYiAqLwogCXN0cnVjdCB0aW1lcl9saXN0 IGlvX3JldHJ5OyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBSZXRy eSB0aW1lciAqLwogCXVuc2lnbmVkIGxvbmcgc3RvcF9yZXRyeTsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAvKiBUaW1lIHRvIGdpdmUgdXAsIGluIGppZmZpZXMg Ki8KIAl1bnNpZ25lZCBpbnQgcmV0cnlfZGVsYXk7ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgLyogRGVsYXkgbGVuZ3RoIGluIG1zICovCg== --------------060906030106010206020205--