linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: 2.6.31-0.1-default-07068-g43c1266 lockdep warning and scheduling while atomic BUG
       [not found] ` <4AB7D9B8.6000501@gmail.com>
@ 2009-09-21 20:04   ` Oliver Neukum
  2009-09-21 20:17     ` Henk Martijn
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2009-09-21 20:04 UTC (permalink / raw)
  To: Henk Martijn, linux-input; +Cc: linux-kernel, H. Peter Anvin

Am Montag, 21. September 2009 21:53:28 schrieb Henk Martijn:
> This is a i7 based DELL and current git throws the following warning and
> bug at me during boot:

Please try this patch

	Regards
		Oliver

--

commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780
Author: Oliver Neukum <oliver@neukum.org>
Date:   Mon Sep 21 22:02:01 2009 +0200

    hid:usbhid: fix wrong use of GFP_KERNEL
    
    hid_input_report() must be told it is called in interrupt context

diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 1b0e07a..ab2869d 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -455,7 +455,7 @@ static void hid_ctrl(struct urb *urb)
 		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
 			hid_input_report(urb->context,
 				usbhid->ctrl[usbhid->ctrltail].report->type,
-				urb->transfer_buffer, urb->actual_length, 0);
+				urb->transfer_buffer, urb->actual_length, 1);
 		break;
 	case -ESHUTDOWN:	/* unplug */
 		unplug = 1;


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: 2.6.31-0.1-default-07068-g43c1266 lockdep warning and scheduling while atomic BUG
  2009-09-21 20:04   ` 2.6.31-0.1-default-07068-g43c1266 lockdep warning and scheduling while atomic BUG Oliver Neukum
@ 2009-09-21 20:17     ` Henk Martijn
  0 siblings, 0 replies; 2+ messages in thread
From: Henk Martijn @ 2009-09-21 20:17 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: linux-input, linux-kernel

Yes that worked, Thanks!

/Henk

Oliver Neukum wrote:
> Am Montag, 21. September 2009 21:53:28 schrieb Henk Martijn:
>> This is a i7 based DELL and current git throws the following warning and
>> bug at me during boot:
> 
> Please try this patch
> 
> 	Regards
> 		Oliver
> 
> --
> 
> commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780
> Author: Oliver Neukum <oliver@neukum.org>
> Date:   Mon Sep 21 22:02:01 2009 +0200
> 
>     hid:usbhid: fix wrong use of GFP_KERNEL
>     
>     hid_input_report() must be told it is called in interrupt context
> 
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index 1b0e07a..ab2869d 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -455,7 +455,7 @@ static void hid_ctrl(struct urb *urb)
>  		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
>  			hid_input_report(urb->context,
>  				usbhid->ctrl[usbhid->ctrltail].report->type,
> -				urb->transfer_buffer, urb->actual_length, 0);
> +				urb->transfer_buffer, urb->actual_length, 1);
>  		break;
>  	case -ESHUTDOWN:	/* unplug */
>  		unplug = 1;
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-21 20:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1253560490.2934.42.camel@localhost>
     [not found] ` <4AB7D9B8.6000501@gmail.com>
2009-09-21 20:04   ` 2.6.31-0.1-default-07068-g43c1266 lockdep warning and scheduling while atomic BUG Oliver Neukum
2009-09-21 20:17     ` Henk Martijn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).