Re: [patch]fix usbhid using GFP_KERNEL in interrupt

[Henk Martijn <h.h.martijn@gmail.com>]

Oliver Neukum wrote:
> hid:usbhid: fix wrong use of GFP_KERNEL
>     
> hid_input_report() must be told it is called in interrupt context
> 
> Signed-off-by: Oliver Neukum <oliver@neukum.org>
> 
> Hi Jiri, Greg,
> 
> this should go into the current tree and the stable tree.
Stable? Interestingly I did not have any problems with 2.6.31......

/Henk
> 
> 	Regards
> 		Oliver
> 
> --
> commit ca5c4a1397d1a1c0d1074f4d8922630fdd732780
> Author: Oliver Neukum <oliver@neukum.org>
> Date:   Mon Sep 21 22:02:01 2009 +0200
> 
>     hid:usbhid: fix wrong use of GFP_KERNEL
>     
>     hid_input_report() must be told it is called in interrupt context
> 
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index 1b0e07a..ab2869d 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -455,7 +455,7 @@ static void hid_ctrl(struct urb *urb)
>  		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
>  			hid_input_report(urb->context,
>  				usbhid->ctrl[usbhid->ctrltail].report->type,
> -				urb->transfer_buffer, urb->actual_length, 0);
> +				urb->transfer_buffer, urb->actual_length, 1);
>  		break;
>  	case -ESHUTDOWN:	/* unplug */
>  		unplug = 1;
> 
>