Re: [PATCH 2/3] Davinci: DM365: Enable DaVinci Key Scan support for DM365 EVM

[Miguel Aguilar <miguel.aguilar@ridgerun.com>]

Dmitry Torokhov wrote:
> On Thu, Sep 24, 2009 at 10:54:00AM -0600, miguel.aguilar@ridgerun.com wrote:
>>  
>> +/* Masks for the various keys on the DM365 EVM */
>> +#define KEY_DM365_KEY2		0
>> +#define KEY_DM365_LEFT		1
>> +#define KEY_DM365_EXIT		2
>> +#define KEY_DM365_DOWN		3
>> +#define KEY_DM365_ENTER		4
>> +#define KEY_DM365_UP		5
>> +#define KEY_DM365_KEY1		6
>> +#define KEY_DM365_RIGHT		7
>> +#define KEY_DM365_MENU		8
>> +#define KEY_DM365_REC		9
>> +#define KEY_DM365_REW		10
>> +#define KEY_DM365_SKIPMINUS	11
>> +#define KEY_DM365_STOP		12
>> +#define KEY_DM365_FF		13
>> +#define KEY_DM365_SKIPPLUL	14
>> +#define KEY_DM365_PLAYPAUSE	15
>> +
>> +#ifdef CONFIG_KEYBOARD_DAVINCI
>> +static unsigned short dm365evm_keymap[] = {
>> +	KEY_DM365_KEY2,
>> +	KEY_DM365_LEFT,
>> +	KEY_DM365_EXIT,
>> +	KEY_DM365_DOWN,
>> +	KEY_DM365_ENTER,
>> +	KEY_DM365_UP,
>> +	KEY_DM365_KEY1,
>> +	KEY_DM365_RIGHT,
>> +	KEY_DM365_MENU,
>> +	KEY_DM365_REC,
>> +	KEY_DM365_REW,
>> +	KEY_DM365_SKIPMINUS,
>> +	KEY_DM365_STOP,
>> +	KEY_DM365_FF,
>> +	KEY_DM365_SKIPPLUL,
>> +	KEY_DM365_PLAYPAUSE,
> 
> These are not standard key codes, why don't you use the ones defined in
> linux/input.h?
> 

These keys make sense for the DM365 EVM, they are defined in the board specific 
file which is the proper way to do that. Using the standard keys would be 
confusing for identifying the real key names defined in the board itself. Is it 
really necessary to use the standard keys?, if not lets keep the board specific 
names.