From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miguel Aguilar Subject: Re: [PATCH 1/3] Input: DaVinci Key Scan Driver Date: Fri, 25 Sep 2009 08:21:28 -0600 Message-ID: <4ABCD1E8.5000200@ridgerun.com> References: <1253811202-21407-1-git-send-email-miguel.aguilar@ridgerun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.navvo.net ([74.208.67.6]:58870 "EHLO mail.navvo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbZIYOVb (ORCPT ); Fri, 25 Sep 2009 10:21:31 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Nori, Sekhar" Cc: "Narnakaje, Snehaprabha" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-input@vger.kernel.org" , "santiago.nunez@ridgerun.com" , "todd.fischer@ridgerun.com" , "clark.becker@ridgerun.com" Nori, Sekhar wrote: > On Thu, Sep 24, 2009 at 22:23:22, miguel.aguilar@ridgerun.com wrote: >> From: Miguel Aguilar >> >> Adds the driver for enabling key scan support for DaVinci platforms. >> >> DM365 is the only platform that uses this driver at the moment. >> >> Signed-off-by: Miguel Aguilar >> --- > > [...] > >> + >> +/* Initializing the kp Module */ >> +static void davinci_ks_initialize(struct davinci_ks *davinci_ks) >> +{ >> + u32 strobe = davinci_ks->pdata->strobe; >> + u32 interval = davinci_ks->pdata->interval; >> + >> + /* Enable all interrupts */ >> + davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_INT_ALL, DAVINCI_KEYSCAN_INTENA); >> + >> + /* Clear interrupts if any */ >> + davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_INT_ALL, DAVINCI_KEYSCAN_INTCLR); >> + >> + /* Setup the scan period = strobe + interval */ >> + davinci_ks_write(davinci_ks, strobe, DAVINCI_KEYSCAN_STRBWIDTH); >> + davinci_ks_write(davinci_ks, interval, DAVINCI_KEYSCAN_INTERVAL); >> + davinci_ks_write(davinci_ks, 0x01, DAVINCI_KEYSCAN_CONTTIME); >> + >> + /* Enable Keyscan module and enable */ >> + davinci_ks_write(davinci_ks, DAVINCI_KEYSCAN_AUTODET | DAVINCI_KEYSCAN_KEYEN, >> + DAVINCI_KEYSCAN_KEYCTRL); > > We seem to be hardcoded to the 4x4 matrix type here. > Some DM365 boards could use 5x3 matrix. > > Thanks, > Sekhar > [MA] I will add a platform option for matrix type to choose 4x4 or 5x3 matrix. What do think about this? Thanks, Miguel Aguilar