linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Aguilar <miguel.aguilar-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
	clark.becker-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	santiago.nunez-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org,
	todd.fischer-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v5 1/2] Input: DaVinci Keypad Driver
Date: Tue, 13 Oct 2009 12:59:19 -0600	[thread overview]
Message-ID: <4AD4CE07.6090801@ridgerun.com> (raw)
In-Reply-To: <20091013181301.GB21593-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>

Dmitry Torokhov wrote:
> Miguel,
> 
> On Tue, Oct 13, 2009 at 11:16:03AM -0600, miguel.aguilar-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org wrote:
>> From: Miguel Aguilar <miguel.aguilar-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org>
>>
>> Adds the driver for enabling keypad support for DaVinci platforms.
>>
>> DM365 is the only platform that uses this driver at the moment.
>>
> 
> Could you please also get rid of davinci_ks_{read,write} - they are
> pointless. I promise this is my last request ;)
Sure, I misunderstood this point. I'll remove those function and call readl and 
writel directly.
> 
> Also - I wonder who "owns" board-specific code (the one your second
> patch is affecting). I usually let arch people to merge it instead of
> goping thruogh input tree.
> 
Kevin Hilman is the one who owns the the DaVinci code.

      parent reply	other threads:[~2009-10-13 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 17:16 [PATCH v5 1/2] Input: DaVinci Keypad Driver miguel.aguilar-9uBrGCPFOa1Wk0Htik3J/w
2009-10-13 18:13 ` Dmitry Torokhov
     [not found]   ` <20091013181301.GB21593-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-10-13 18:59     ` Miguel Aguilar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD4CE07.6090801@ridgerun.com \
    --to=miguel.aguilar-9ubrgcpfoa1wk0htik3j/w@public.gmane.org \
    --cc=clark.becker-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=santiago.nunez-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org \
    --cc=todd.fischer-9uBrGCPFOa1Wk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).