From: Ben Dooks <ben@simtec.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Shine Liu <shinel@foxmail.com>,
linux-samsung-soc@vger.kernel.org, dmitry.torokhov@gmail.com,
Arnaud Patard <arnaud.patard@rtp-net.org>,
linux-input@vger.kernel.org,
Simtec Linux Team <linux@simtec.co.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.
Date: Thu, 19 Nov 2009 12:06:11 +0000 [thread overview]
Message-ID: <4B0534B3.20907@simtec.co.uk> (raw)
In-Reply-To: <20091119103717.GC15460@sirena.org.uk>
Mark Brown wrote:
> On Thu, Nov 19, 2009 at 01:46:55PM +0800, Shine Liu wrote:
>> On Wed, 2009-11-18 at 23:29 +0000, Ben Dooks wrote:
>
>>> +config TOUCHSCREEN_S3C2410
>>> + tristate "Samsung S3C2410 touchscreen input driver"
>>> + depends on ARCH_S3C2410 && INPUT && INPUT_TOUCHSCREEN
>>> + select SERIO
>>> + help
>>> + Say Y here if you have the s3c2410 touchscreen.
>>> +
>>> + If unsure, say N.
>>> +
>>> + To compile this driver as a module, choose M here: the
>>> + module will be called s3c2410_ts.
>
>> S3C24XX_ADC should be added to the depends.
>
> It's probably more friendly to select rather than depend on it to avoid
> the option being hidden.
I prefer the 'select S3C24XX_ADC' and have the symbol available.
Will update the patch.
next prev parent reply other threads:[~2009-11-19 11:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091118232939.201290297@fluff.org.uk>
2009-11-18 23:29 ` [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard Ben Dooks
2009-11-19 1:45 ` Ramax Lo
2009-11-19 2:59 ` Dmitry Torokhov
2009-11-19 5:47 ` Harald Welte
2009-11-19 6:15 ` Shine Liu
2009-11-19 11:34 ` Ben Dooks
2009-11-19 13:52 ` Daniel Silverstone
2009-11-19 17:03 ` Dmitry Torokhov
2009-11-19 17:12 ` Russell King - ARM Linux
2009-11-19 17:48 ` Ben Dooks
2009-11-19 17:14 ` Dmitry Torokhov
2009-11-27 7:31 ` Pavel Machek
2009-11-19 5:46 ` Shine Liu
2009-11-19 10:37 ` Mark Brown
2009-11-19 12:06 ` Ben Dooks [this message]
2009-11-19 8:04 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0534B3.20907@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=arnaud.patard@rtp-net.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@simtec.co.uk \
--cc=shinel@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).