From: Peter Hutterer <peter.hutterer@redhat.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add multi-input quirk for NextWindow Touchscreen.
Date: Fri, 04 Dec 2009 08:07:34 +1000 [thread overview]
Message-ID: <4B1836A6.405@redhat.com> (raw)
In-Reply-To: <87zl60s17o.fsf@macbook.be.48ers.dk>
On 03/12/09 22:15, Peter Korsgaard wrote:
>>>>>> "Peter" == Peter Hutterer<peter.hutterer@redhat.com> writes:
>
> Peter> These touchscreens are mounted onto HP TouchSmart and the Dell
> Peter> Studio One 19. Without a quirk they report a wrong button set
> Peter> and the x/y coordinates through ABS_Z/ABS_RX, confusing the
> Peter> higher levels (most notably X.Org's evdev driver).
>
> What exactly does this fix? I've been using NW touchscreens for a while
> and don't recall any issues (admittedly only used it with evtouch).
evtouch has the following code:
if ( (ev->code == ABS_X) || (ev->code == ABS_Z) ) {
priv->raw_x = ev->value;
pos_changed = 1;
}
if ( (ev->code == ABS_Y) || (ev->code == ABS_RX) ) {
priv->raw_y = ev->value;
pos_changed = 1;
}
it's a hack in userspace that works around wrong event reporting. So
yes, it works if you're using evtouch but if you want to use any other
driver that driver needs the same hack. treating Z as X and RX as Y
doesn't work too well for a generic driver such as evdev, which has to
deal with devices where RX is a valid axis.
Cheers,
Peter
next prev parent reply other threads:[~2009-12-03 22:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 5:08 [PATCH] HID: add multi-input quirk for NextWindow Touchscreen Peter Hutterer
2009-12-03 9:52 ` Jiri Kosina
2009-12-03 12:15 ` Peter Korsgaard
2009-12-03 22:07 ` Peter Hutterer [this message]
2009-12-04 12:59 ` Peter Korsgaard
2009-12-04 13:24 ` Peter Hutterer
[not found] ` <4B190D88.4090102-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-12-04 13:40 ` Peter Korsgaard
2009-12-07 5:46 ` Peter Hutterer
[not found] ` <4B1C96C4.5080709-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-12-09 9:42 ` Peter Korsgaard
2009-12-17 20:30 ` Peter Korsgaard
2009-12-18 5:02 ` Peter Hutterer
[not found] ` <4B2B0CCE.2020406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-12-19 22:05 ` Peter Korsgaard
[not found] ` <87638239ha.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2009-12-20 23:48 ` Peter Hutterer
2009-12-21 7:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1836A6.405@redhat.com \
--to=peter.hutterer@redhat.com \
--cc=jacmet@sunsite.dk \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).